-
Notifications
You must be signed in to change notification settings - Fork 32
Repeating groups: Validation trigger for single row #468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
area/validation
related to form validation rules/messages
kind/feature-request
New feature or request
org/ssb
Issues relevant for Statistisk sentralbyrå.
ux
Needs some love from a UX resource
Comments
Implementing this feature might solve the bug: |
5 tasks
Repository owner
moved this from ⚠ Blocked
to 🧪 Testing
in Improvements repeating groups
Nov 2, 2022
Repository owner
moved this from 🔎 Review
to ✅ Done
in Team Apps
Nov 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/validation
related to form validation rules/messages
kind/feature-request
New feature or request
org/ssb
Issues relevant for Statistisk sentralbyrå.
ux
Needs some love from a UX resource
Description
Currently, adding
"triggers": ["validation"]
on a repeating group element will trigger validation for all rows inside the group when attempting to save/close one row. This is not what one might intuitively expect.Suggestions
validation
trigger for repeating groups trigger validation for the row (a breaking change) and optionally introduce a newvalidateRows
orvalidateAllRows
specifically for groups, where all rows are validated (as they were before), if this is functionality we need.validateRow
trigger for repeating groups, which only validates the current row, leaving thevalidation
trigger as it is now.Example
The current solution leads to lots of noise in the UI when saving a row in a repeating group you haven't started filling out yet. This example is taken from an app that creates semi-filled rows the user have to expand to fill, but saving one of them validates all of them:
The text was updated successfully, but these errors were encountered: