Skip to content

Validation trigger for single row #594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Nov 2, 2022
Merged

Validation trigger for single row #594

merged 10 commits into from
Nov 2, 2022

Conversation

bjosttveit
Copy link
Member

@bjosttveit bjosttveit commented Oct 31, 2022 •
edited
Loading

Description

Added a new trigger, validateRow, that only triggers validation for the current row when clicking save and close, as opposed to validating all of the elements in the repeating group.

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@bjosttveit bjosttveit linked an issue Oct 31, 2022 that may be closed by this pull request
Repeating groups: Validation trigger for single row #468
Closed
@olemartinorg olemartinorg self-requested a review November 1, 2022 08:07
olemartinorg
olemartinorg reviewed Nov 1, 2022
View reviewed changes
Copy link
Contributor

@olemartinorg olemartinorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far! 🎉

@bjosttveit bjosttveit force-pushed the single-row-validation branch from f483522 to 0ca9d5e Compare November 1, 2022 09:32
@bjosttveit bjosttveit force-pushed the single-row-validation branch from 0ca9d5e to 6229a7c Compare November 1, 2022 09:38
@bjosttveit bjosttveit force-pushed the single-row-validation branch from 47523a9 to 285d33e Compare November 1, 2022 10:00
@github-actions github-actions bot added the area/test related to automated and functional testing label Nov 1, 2022
@bjosttveit bjosttveit force-pushed the single-row-validation branch from a410502 to 37c7ca2 Compare November 1, 2022 14:50
@bjosttveit bjosttveit force-pushed the single-row-validation branch from 37c7ca2 to 0dc5a05 Compare November 1, 2022 14:52
@bjosttveit bjosttveit marked this pull request as ready for review November 2, 2022 07:26
@bjosttveit bjosttveit mentioned this pull request Nov 2, 2022
Merged
@bjosttveit bjosttveit mentioned this pull request Nov 2, 2022
Closed
@bjosttveit
Copy link
Member Author

Cypress:

image

olemartinorg
olemartinorg approved these changes Nov 2, 2022
View reviewed changes
Copy link
Contributor

@olemartinorg olemartinorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean!! 👏

Ole Martin Handeland added 3 commits November 2, 2022 10:43
Merge branch 'main' into single-row-validation
c0bca4a 
# Conflicts:
#	src/altinn-app-frontend/src/features/form/containers/GroupContainer.tsx
#	src/altinn-app-frontend/src/utils/validation/validation.ts
Merge branch 'main' into single-row-validation
9ffd073
Fixing nullable values
9840745
@olemartinorg
Copy link
Contributor

Seems like there is some flakyness in the cypress tests now - unsure if that was my fault (with all the nullable checks) or something that happened with these changes. Would you mind running the cypress tests repeatedly (those that are failing) and figure out the root cause, @bjosttveit?

@bjosttveit
Copy link
Member Author

Seems like there is some flakyness in the cypress tests now - unsure if that was my fault (with all the nullable checks) or something that happened with these changes. Would you mind running the cypress tests repeatedly (those that are failing) and figure out the root cause, @bjosttveit?

Looks like it broke somehow, at least the test works! Will look into it

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 2, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

67.6% 67.6% Coverage
0.0% 0.0% Duplication

@bjosttveit bjosttveit merged commit 686065a into main Nov 2, 2022
@bjosttveit bjosttveit deleted the single-row-validation branch November 2, 2022 12:15
@StianVestli
Copy link

Testet litt og det ser ut som det funker fint, eneste er at man er tvunget til å fylle ut før man får lukket raden, mulig det er helt ok, får se når flere får testet dette.

@StianVestli StianVestli mentioned this pull request Nov 8, 2022
Closed
@olemartinorg olemartinorg added the kind/product-feature Pull requests containing new features label Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olemartinorg olemartinorg olemartinorg approved these changes

@Magnusrm Magnusrm Awaiting requested review from Magnusrm

Assignees
No one assigned
Labels
area/test related to automated and functional testing kind/product-feature Pull requests containing new features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Repeating groups: Validation trigger for single row
3 participants
@bjosttveit @olemartinorg @StianVestli