Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repeating groups: Overflowing table squashes button #469

Closed
olemartinorg opened this issue Sep 14, 2022 · 1 comment · Fixed by #650
Closed

Repeating groups: Overflowing table squashes button #469

olemartinorg opened this issue Sep 14, 2022 · 1 comment · Fixed by #650
Assignees
Labels
kind/bug Something isn't working org/ssb Issues relevant for Statistisk sentralbyrå. ux Needs some love from a UX resource

Comments

@olemartinorg
Copy link
Contributor

Description of the bug

In some cases, large tables used for previewing repeating group contents can lead to squashed buttons:

bug-squashed-button

To a human it's quite obvious that the two columns containing numbers here should get less screen-space, and the title-columns and button-columns should get more (to fill them).

I'll be the first to point out that I've spent a considerable amount of time in a previous project trying to intelligently manage column widths in data tables to make sure content is spaced out to maximize screen real estate - so I would suggest a simpler solution where app developers can control this instead.

Suggestion 1 (large effort)

It seems to be the case that table headers currently overflow to use multiple lines, making sure to fit all the text. For the table body however, content is cut off with ellipsis when overflowing.

Allow for options to control the width of each column, i.e.:

  • A fixed percentage of the full width (i.e. 20%)
  • Non-breaking, use as much space as is needed (default for the button column)
  • Divide the rest of the available width equally (this seems to be the default for non-button columns)
  • Possibly allow for options to display the full content over multiple lines without ellipsis when overflowing (UX needs to be considered)

Suggestion 2 (smaller effort)

Make sure the button column is displayed in full. ✌️

Steps To Reproduce

  1. Create a group/table with lots of content
  2. Force buttons to have long labels, or cause validation to increase the size of the buttons
  3. Observe something similar to the screenshot above

Additional Information

This could also have a certain overlap with the table project

@olemartinorg olemartinorg added kind/bug Something isn't working org/ssb Issues relevant for Statistisk sentralbyrå. ux Needs some love from a UX resource labels Sep 14, 2022
@rvessb rvessb added this to Issues SSB Oct 7, 2022
@RonnyB71 RonnyB71 moved this to 📈 Todo in Team Apps Oct 14, 2022
@olemartinorg
Copy link
Contributor Author

Consider if we should wait until the new Table design from the design system arrives before we look more into this. As soon as that is implemented in app-frontend, this might all change and this issue might not be relevant anymore.

@bjosttveit bjosttveit self-assigned this Oct 26, 2022
@bjosttveit bjosttveit moved this from 📈 Todo to 👷 In Progress in Team Apps Oct 26, 2022
@bjosttveit bjosttveit removed their assignment Oct 26, 2022
@bjosttveit bjosttveit moved this from 👷 In Progress to 📈 Todo in Team Apps Oct 26, 2022
@olemartinorg olemartinorg moved this from 📈 Todo to ⚠️ Blocked in Team Apps Oct 27, 2022
@olemartinorg olemartinorg moved this to Todo in Issues SSB Nov 2, 2022
@bjosttveit bjosttveit linked a pull request Dec 8, 2022 that will close this issue
3 tasks
@bjosttveit bjosttveit self-assigned this Dec 8, 2022
Repository owner moved this from 📈 Todo to 🧪 Testing in Improvements repeating groups Dec 9, 2022
Repository owner moved this from Todo to Done in Issues SSB Dec 9, 2022
@bjosttveit bjosttveit moved this from ⚠️ Blocked to 🧪 Test in Team Apps Dec 9, 2022
@Magnusrm Magnusrm moved this from 🧪 Test to ✅ Done in Team Apps Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working org/ssb Issues relevant for Statistisk sentralbyrå. ux Needs some love from a UX resource
Projects
Archived in project
Archived in project
Status: 🧪 Testing
Development

Successfully merging a pull request may close this issue.

2 participants