Use new table component in repeating groups #650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjosttveit
force-pushed
the
feat/new-table-in-repeating-groups
branch
from
dac0a00 to
fd3936f
Compare
olemartinorg
added
the
kind/product-feature
bjosttveit
force-pushed
the
feat/new-table-in-repeating-groups
branch
from
5238dff to
d1c524f
Compare
bjosttveit
changed the title
bjosttveit
force-pushed
the
feat/new-table-in-repeating-groups
branch
from
97376be to
888fb07
Compare
bjosttveit
force-pushed
the
feat/new-table-in-repeating-groups
branch
from
888fb07 to
d1b5470
Compare
github-actions
bot
added
the
area/test
bjosttveit
requested review from
Magnusrm and
olemartinorg
and removed request for
Magnusrm
olemartinorg
approved these changes
Dec 9, 2022
src/altinn-app-frontend/src/features/form/containers/GroupContainer.tsx
Outdated
Show resolved
Hide resolved
src/altinn-app-frontend/src/features/form/containers/RepeatingGroupTable.tsx
Outdated
Show resolved
Hide resolved
# Conflicts: # cypress/e2e/pageobjects/app-frontend.js # package.json # src/features/form/containers/RepeatingGroupTable.tsx # src/features/form/containers/RepeatingGroupsEditContainer.tsx # yarn.lock
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updating repeating groups to use the new
Table-component from the design system instead of the oldAltinnTable. In order to achieve a styling similar to that in figma (full width and lining up columns with the rest of the page for example) a lot of custom styling was added.Note: Will conflict heavily with #714
Desktop:
Nested desktop:
Mobile:
Nested mobile:
Related Issue(s)
Verification
Relevant automated test added (if you find this hard, leave it and we'll help out)Documentation
User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)