Use new table component in repeating groups (#650)

* first step * visuals * error styling * improved desktop layout * of course safari has an edge-case for exactly 0 width 😤 * missing space * fix width * make nested group look good * smaller padding for nested group * column alignment * update icon * update design-system * wcag * mobile layout * remove empty columns and fix group tests * fix editRowIndex * spacing (mobile) * remove reference to altinn-mobile-table in unit test * fix colspan * fix french button * Updating broken import * move to fullwidthwrapper Co-authored-by: Ole Martin Handeland <git@olemartin.org>
Altinn · Dec 9, 2022 · 08f73bc · 08f73bc
1 parent 1f7b7bf
commit 08f73bc
Show file tree

Hide file tree

Showing 23 changed files with 696 additions and 699 deletions.
diff --git a/babel.config.json b/babel.config.json
@@ -1,9 +1,4 @@
 {
-  "presets": [
-    "@babel/preset-env",
-    "@babel/preset-react"
-  ],
-  "ignore": [
-    "/**/*.json"
-  ]
+  "presets": ["@babel/preset-env", "@babel/preset-react"],
+  "ignore": ["/**/*.json"]
 }
diff --git a/cypress/README.md b/cypress/README.md
@@ -12,8 +12,7 @@ These instructions will get you run the integration tests on altinn-app-frontend
     yarn --immutable # only needed first time, or when dependencies are updated
 ```
 
-If you are running locally you need a copy of [altinn-studio](https://github.com/altinn/altinn-studio).
-    - Make sure you have followed instructions on [running apps locally](https://github.com/Altinn/altinn-studio/blob/5c05d4c32be1b24ddd5af9ddd661b2c78f65aad4/LOCALAPP.md).
+If you are running locally you need a copy of [altinn-studio](https://github.com/altinn/altinn-studio). - Make sure you have followed instructions on [running apps locally](https://github.com/Altinn/altinn-studio/blob/5c05d4c32be1b24ddd5af9ddd661b2c78f65aad4/LOCALAPP.md).
 
 ### Test data prerequisite
 

diff --git a/cypress/e2e/fixtures/allowed-parties.json b/cypress/e2e/fixtures/allowed-parties.json
@@ -1,42 +1,42 @@
-[  
+[
   {
-      "partyId": 500000,
-      "partyTypeName": 2,
-      "orgNumber": "897069650",
-      "ssn": null,
-      "unitType": "AS",
-      "name": "DDG Fitness AS",
-      "isDeleted": false,
-      "onlyHierarchyElementWithNoAccess": false,
-      "person": null,
-      "organization": null,
-      "childParties": [
-          {
-              "partyId": 500001,
-              "partyTypeName": 2,
-              "orgNumber": "897069651",
-              "ssn": null,
-              "unitType": "BEDR",
-              "name": "DDG Fitness Bergen",
-              "isDeleted": false,
-              "onlyHierarchyElementWithNoAccess": false,
-              "person": null,
-              "organization": null,
-              "childParties": null
-          }
-      ]
+    "partyId": 500000,
+    "partyTypeName": 2,
+    "orgNumber": "897069650",
+    "ssn": null,
+    "unitType": "AS",
+    "name": "DDG Fitness AS",
+    "isDeleted": false,
+    "onlyHierarchyElementWithNoAccess": false,
+    "person": null,
+    "organization": null,
+    "childParties": [
+      {
+        "partyId": 500001,
+        "partyTypeName": 2,
+        "orgNumber": "897069651",
+        "ssn": null,
+        "unitType": "BEDR",
+        "name": "DDG Fitness Bergen",
+        "isDeleted": false,
+        "onlyHierarchyElementWithNoAccess": false,
+        "person": null,
+        "organization": null,
+        "childParties": null
+      }
+    ]
   },
   {
-      "partyId": 500600,
-      "partyTypeName": 2,
-      "orgNumber": "897069631",
-      "ssn": null,
-      "unitType": "AS",
-      "name": "EAS Health Consulting",
-      "isDeleted": true,
-      "onlyHierarchyElementWithNoAccess": false,
-      "person": null,
-      "organization": null,
-      "childParties": []
-  }  
-]
+    "partyId": 500600,
+    "partyTypeName": 2,
+    "orgNumber": "897069631",
+    "ssn": null,
+    "unitType": "AS",
+    "name": "EAS Health Consulting",
+    "isDeleted": true,
+    "onlyHierarchyElementWithNoAccess": false,
+    "person": null,
+    "organization": null,
+    "childParties": []
+  }
+]
diff --git a/cypress/e2e/fixtures/attachment.json b/cypress/e2e/fixtures/attachment.json
@@ -1,10 +1,10 @@
 {
-  "id": "326e50d6-befd-445d-a2d2-999e411748c0",  
+  "id": "326e50d6-befd-445d-a2d2-999e411748c0",
   "dataType": "fileUpload-message",
   "filename": "test.pdf",
-  "contentType": "application/pdf",  
+  "contentType": "application/pdf",
   "selfLinks": {
-    "apps": "https://altinn3local.no/ttd/frontend-test/instances/"    
+    "apps": "https://altinn3local.no/ttd/frontend-test/instances/"
   },
   "size": 4,
   "locked": false,

diff --git a/cypress/e2e/pageobjects/app-frontend.js b/cypress/e2e/pageobjects/app-frontend.js
@@ -197,8 +197,8 @@ export default class AppFrontend {
       rows: [0, 1].map((idx) => ({
         uploadSingle: makeUploaderSelectors('mainUploaderSingle', idx, 3),
         uploadMulti: makeUploaderSelectors('mainUploaderMulti', idx, 4),
-        editBtn: `#group-mainGroup-table-body > tr:nth-child(${idx + 1}) > td:nth-last-of-type(2n) > div > button`,
-        deleteBtn: `#group-mainGroup-table-body > tr:nth-child(${idx + 1}) > td:last-of-type > div > button`,
+        editBtn: `#group-mainGroup-table-body > tr:nth-child(${idx + 1}) > td:nth-last-of-type(2n) button`,
+        deleteBtn: `#group-mainGroup-table-body > tr:nth-child(${idx + 1}) > td:last-of-type button`,
         nestedGroup: {
           rows: [0, 1].map((subIdx) => ({
             uploadTagMulti: makeUploaderSelectors('subUploader', `${idx}-${subIdx}`, 2, true),
@@ -208,12 +208,8 @@ export default class AppFrontend {
               `#nestedOptions-${idx}-${subIdx} input[type=checkbox]:nth(1)`,
               `#nestedOptions-${idx}-${subIdx} input[type=checkbox]:nth(2)`,
             ],
-            editBtn: `#group-subGroup-${idx}-table-body > tr:nth-child(${
-              subIdx + 1
-            }) > td:nth-last-of-type(2n) > div > button`,
-            deleteBtn: `#group-subGroup-${idx}-table-body > tr:nth-child(${
-              subIdx + 1
-            }) > td:last-of-type > div > button`,
+            editBtn: `#group-subGroup-${idx}-table-body > tr:nth-child(${subIdx + 1}) > td:nth-last-of-type(2n) button`,
+            deleteBtn: `#group-subGroup-${idx}-table-body > tr:nth-child(${subIdx + 1}) > td:last-of-type button`,
           })),
           groupContainer: `#group-subGroup-${idx}`,
           saveBtn: `#add-button-grp-subGroup-${idx}`,