Enable expressions for TextResourceBindings and per row in repeating groups #714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/instantiation
area/test
|
Looking forward to all of the merge conflicts i'm gonna get 😩 |
Magnusrm
changed the title
5 tasks
3 tasks
added 3 commits
December 9, 2022 12:46
…ng-groups # Conflicts: # src/components/molecules/AltinnMobileTableItem.tsx # src/features/form/containers/RepeatingGroupTable.tsx # src/features/form/containers/RepeatingGroupTableRow.tsx
…s-for-prefil-in-repeating-groups
…s-for-prefil-in-repeating-groups
bjosttveit
reviewed
Dec 12, 2022
Co-authored-by: Ole Martin Handeland <github@olemartin.org>
…alue for all the values in that object containing an expression
…s-for-prefil-in-repeating-groups
|
Kudos, SonarCloud Quality Gate passed! |
Magnusrm
deleted the
feature/61-expressions-for-prefil-in-repeating-groups
branch
standeren
pushed a commit
that referenced
this pull request
Dec 13, 2022
…groups (#714) * expressions per row and use expressions for textresourcebindings * comply with tests * create cypress test * default values for textResourceBindings, some cleanup * update layout.schema * refactor repeatingGroupRow, some cleanup * Minor changes to make future merge easier (will be reverted) * Cleaning up after merge * change edit button color * Add breakword * Fix styling * fix mobile button placement * fix lint errors * Update cypress/e2e/integration/app-frontend/group.js Co-authored-by: Ole Martin Handeland <github@olemartin.org> * Implementing a magic key in an object that can be used as a default value for all the values in that object containing an expression * merge origin/main into branch Co-authored-by: Ole Martin Handeland <git@olemartin.org> Co-authored-by: = <bjosttveit@gmail.com> Co-authored-by: Ole Martin Handeland <github@olemartin.org>
olemartinorg
pushed a commit
that referenced
this pull request
Dec 13, 2022
… the shared test framework. We had support for this in useExpressions() after #714, but this is not natively supported in the shared test bootstrapping.
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enables expressions to be used for TextResourceBindings
Enables expressions to be calculated using row-specific values when useExpressions is given a rowIndex in a group component context.
The use of TextResourceBindings have been updated to run expressions using
useExpressionsbefore being taken into use by components.useExpressionshave been updated to check whether the given component is a group, and if a rowIndex is given the expression will run using a the context of a child-component in the given index.Related Issue(s)
Verification
layout/index.tsandlayout.schema.v1.json, and these are all backwards-compatible