Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syncing expression tests with app-lib-dotnet #741

Merged
merged 4 commits into from
Dec 15, 2022

Conversation

olemartinorg
Copy link
Contributor

Description

This adds a new test that tests on-group contexts, which was added to useExpressions() in #714, but required a separate implementation in the test bootstrapping to work there.

This PR also changes a few things in the eslint config so that these shared tests are ignored. We don't want to fuss over whitespace changes, and having prettier rule over these tests in both repos that needs to have these tests.

Related Issue(s)

Verification

  • Manual testing
    • I have tested these changes manually
    • Creator of the original issue (or service owner) has been contacted for manual testing
    • No testing done/necessary
  • Automated tests
    • Unit test(s) have been added
    • Cypress E2E test(s) have been added
    • No automatic tests are needed here
    • I want someone to help me make some tests
  • User documentation @ altinn-studio-docs
    • Has been updated
    • No changes/updates needed
  • Changes/additions to component properties
    • Changes are reflected in both layout/index.ts and layout.schema.v1.json, and these are all backwards-compatible
    • No changes made
  • Support in Altinn Studio
    • Issue(s) created for support in Studio
    • This change/feature does not require any changes to Altinn Studio
  • Sprint board
    • The original issue (or this PR itself) has been added to the Team Apps project and to the current sprint board

Ole Martin Handeland added 4 commits December 13, 2022 19:15
… the shared test framework. We had support for this in useExpressions() after #714, but this is not natively supported in the shared test bootstrapping.
…ore patterns in .eslintrc.json will be respected for shared tests
@olemartinorg olemartinorg added the kind/other Pull requests containing chores/repo structure/other changes label Dec 13, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@olemartinorg olemartinorg added the ignore-for-release Pull requests to be ignored in release notes label Dec 14, 2022
@olemartinorg olemartinorg merged commit 5b5111b into main Dec 15, 2022
@olemartinorg olemartinorg deleted the feat/shared-tests-sync branch December 15, 2022 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-for-release Pull requests to be ignored in release notes kind/other Pull requests containing chores/repo structure/other changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants