Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the layout schema(s) to this repo #550

Closed
olemartinorg opened this issue Oct 17, 2022 · 0 comments · Fixed by #613
Closed

Move the layout schema(s) to this repo #550

olemartinorg opened this issue Oct 17, 2022 · 0 comments · Fixed by #613

Comments

@olemartinorg
Copy link
Contributor

The CDN repo has some schemas, and among them we have the layout.schema. While this file defines the contract used by both app-frontend-react and altinn-studio, changes to this file usually follows a certain route:

  1. A new feature/fix is implemented in app-frontend-react, requiring changes to the layout schema
  2. The change is made to a fork of altinn-cdn (because of missing permissions to create branches), and a PR will usually hang around for a bit too long before being merged (again because of missing permissions).
  3. A long time after this is done, the options to control this from Altinn Studio might be implemented

As changes usually follows this route (and are rarely/never implemented in Studio first - that would just produce invalid layout files app-frontend cannot read), it makes sense to move this file to this repo. That would also keep updates to the file in sync with the latest release of app-frontend-react, as we'd push the changes to altinn-cdn at the time of release.

@olemartinorg olemartinorg moved this to 📈 Todo in Team Apps Oct 17, 2022
@olemartinorg olemartinorg moved this from 📈 Todo to 👷 In Progress in Team Apps Nov 2, 2022
@olemartinorg olemartinorg self-assigned this Nov 2, 2022
@olemartinorg olemartinorg linked a pull request Nov 2, 2022 that will close this issue
4 tasks
@olemartinorg olemartinorg moved this from 👷 In Progress to 🔎 Review in Team Apps Nov 2, 2022
@olemartinorg olemartinorg removed their assignment Nov 2, 2022
Repository owner moved this from 🔎 Review to ✅ Done in Team Apps Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant