Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moving JsonSchemas into this repo #613

Merged
merged 52 commits into from
Nov 3, 2022
Merged

Moving JsonSchemas into this repo #613

merged 52 commits into from
Nov 3, 2022

Conversation

olemartinorg
Copy link
Contributor

Description

Currently there are multiple open PRs in the CDN repo, and these 'never' seem to be merged, and most don't have privileges to merge them. Adding to that, functionality (most often implemented in this repo first) is what makes changes to these schemas necessary. Because of this, moving the schemas here is obviously better - and we can roll out changes to them at the exact same time as we release new versions of app-frontend.

Of note here:

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • [ ] User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

lorang92 and others added 30 commits November 18, 2020 12:34
@lorang92
Allowing additional props (#7)
0010a6d
@lorang92
Added missing trigger field (#8)
b8f73df
@tba76
Config for excludeFromPdf (#9)
d43d620
@nkylstad
Added summary component definitions (#11)
e7b88f8 
Co-authored-by: Kylstad <acn-nkyls@ai-dev.no>
@lorang92
Added validate page + pages as trigger enum (#12)
9fc10d5
@lorang92
Added missing properties for layoutSettings json-schema (#14)
3f56010
@nkylstad
Feature/5233 message widget (#15)
8e4c93a 
* add message widget

* test with multiple widgets

* update message text key

* update widgets

* widget updates

* update layout schema with new component type

* update schema for attachment list component

* updated after pr comments
@lorang92
feature/4497-json-schema-cdn (#6)
a7f5d8f 
Added schemas for layout
@SandGrainOne
Added LabelSettings to layout schema (#23)
f2accde
@lorang92
Added grid prop to json-schema (#26)
f69e9e8 
* Added grid prop to json-schema

Altinn/altinn-studio#1515
@lorang92 @lorangSec
Added new trigger + triggers on page level on json schemas (#29)
df24e16 
* Added new trigger + triggers on page level on json schemas

* Added title

Co-authored-by: EKEBERG Steffen <steffen.ekeberg@soprasteria.com>
@lorang92 @lorangSec
Added new trigger + triggers on page level on json schemas (#29)
e2e3d04 
* Added new trigger + triggers on page level on json schemas

* Added title

Co-authored-by: EKEBERG Steffen <steffen.ekeberg@soprasteria.com>
@lorang92
Changed example to be consistent with docs (#34)
5b79ae6
@nkylstad
add group edit property to layout schema (#38)
74be7ac
@nkylstad
Add formatting property for input component. (#39)
11bd2bb 
* Add formatting property for input component.

* number format schema

* test number-format schema

* fix misplaced elements

* update required condition

* add missing newline

* update conditional required

* test new condition

* test updated schema

* working schemas

* add default values
@lorang92
feature/4497-json-schema-cdn (#6)
b9f6250 
Added schemas for layout
@nkylstad
Add formatting property for input component. (#39)
316a59d 
* Add formatting property for input component.

* number format schema

* test number-format schema

* fix misplaced elements

* update required condition

* add missing newline

* update conditional required

* test new condition

* test updated schema

* working schemas

* add default values
@ivarne
Add JsonSchema for Input field text alignment (#55)
eaf88b0 
Corresponding change for Altinn/altinn-studio#7034
@ivarne
Add JSON schema pattern for layout.id (#54)
5ec05fa 
* Add JSON schema pattern for layout.id
@ivarne
Specify that groupComponents.children, needs to be unique (#62)
1619c9f 
* Specify that groupComponents.children, needs to be unique

Altinn studio designer crashes if there are duplicate entries in groupComponents.children. It will be much easier to catch if VSCode complains.

* Clarify help text
@FTLems
Added image in schema-validator (#63)
5d12cf6 
* Added image in schema-validator

* Correction acc. to comments
@DanRJ @lorang92
Add explanation of the keyword 'today' (#64)
8f9335d 
* Add explanation of the keyword 'today'

* Update schemas/json/layout/layout.schema.v1.json

Co-authored-by: Steffen Lorang Ekeberg <steffen.ekeberg@gmail.com>

* Fix description after feedback on PR

* Remove extra quote character

Co-authored-by: Steffen Lorang Ekeberg <steffen.ekeberg@gmail.com>
@lorang92
Added tableHeaders to json schema (#68)
92f46a6 
* Added tableHeaders to json schema
@ivarne @lorang92
Added Json schema for labelGrid (#56)
7910cde 
* Added Json schema for labelGrid

Altinn/altinn-studio#7027

* Update schemas/json/layout/layout.schema.v1.json

Co-authored-by: Steffen Lorang Ekeberg <steffen.ekeberg@gmail.com>

* Fix indentation levels in layout.schema.v1.json.

Co-authored-by: Steffen Lorang Ekeberg <steffen.ekeberg@gmail.com>
@ivarne
Add typings for "Header" component (#70)
a8d19cc
@lorang92 @SandGrainOne @lorangSec
Added instantiation button to schema (#74)
d05d1f7 
* Update schemas/json/layout/layout.schema.v1.json

Co-authored-by: Terje Holene <terje.holene@gmail.com>
Co-authored-by: EKEBERG Steffen <steffen.ekeberg@soprasteria.com>
@haakemon
feat: allow h2, h3, h4 as values for header size (#77)
7dccc08
@lorang92 @lorangSec
added new prop to group (#78)
6aa7d51 
Co-authored-by: EKEBERG Steffen <steffen.ekeberg@soprasteria.com>
@haakemon
fix: update documentation to specify correct default value fot timest…
aefa09c 
…amp for date picker component (#82)

The implementation actually defaults to 'undefined', and there is a strict check if the timestamp is set to 'false'.
The result of this check (timestamp === false) will only be true if timestamp is 'false'. 'undefined' (default) will not result in this check evaluating to 'true'.
@ivarne
Fix typo in layout.schema.v1.json (#87)
a3ef457
Truls Gunnerød and others added 16 commits May 6, 2022 16:33
utvidet layoutSettings til å inneholde hideCloseButton og showLanguag…
261eef4 
…eDropdown
Renamed the schema-description from showLanguageDropdown to showLangu…
75ffa1c 
…ageSelector
@haakemon
feat: add schema definition for Panel component (#100)
44f8aef
@olemartinorg
Adding layout schema support for the new saveWhileTyping property (#104)
5083f51 
Co-authored-by: Ole Martin Handeland <git@olemartin.org>
@mjulstein
PrintButton in schema (#101)
be3deac 
Co-authored-by: Martin Joakim Ulstein <mjulstein@users.noreply.github.com>
@lorang92 @lorangSec
feat: group panel schema (#105)
a69a42a 
Co-authored-by: EKEBERG Steffen <steffen.ekeberg@soprasteria.com>
@olemartinorg
Bringing the json schema in sync with the definitions in app-frontend (…
815f64d 
…#106)

Co-authored-by: Ole Martin Handeland <git@olemartin.org>
@nkylstad
added likert component to layout schema (#107)
df1355a
@lorang92 @lorangSec
feat: added multiple select (#110)
41a35ce 
Co-authored-by: EKEBERG Steffen <steffen.ekeberg@soprasteria.com>
@nkylstad
update summary component schema (#109)
8b0d247
@Magnusrm
add alertOnDelete to layout schema (#113)
204bc76
@TheTechArch
Added layoutset schema (#17)
95bab7c 
* Added layoutset schema

* Changed to tasks

* feedback

* empty line
@bjosttveit
Added trigger for single-row-validation
d6a50f0
Moving most of the complexity of release scripting into a bash script…
5c87a63 
… (which is easy to run locally for testing)
Fixing formatting in the layout-sets schema
9ea4022
Adding schema-copy to cdn
57f0c6c
@olemartinorg olemartinorg linked an issue Nov 2, 2022 that may be closed by this pull request
Move the layout schema(s) to this repo #550
Closed
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@olemartinorg olemartinorg requested a review from tjololo November 2, 2022 22:29
Magnusrm
Magnusrm approved these changes Nov 3, 2022
View reviewed changes
Copy link
Contributor

@Magnusrm Magnusrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Looks good to me 👍

bjosttveit
bjosttveit approved these changes Nov 3, 2022
View reviewed changes
Copy link
Member

@bjosttveit bjosttveit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good!

@olemartinorg olemartinorg merged commit 6ebaa4f into main Nov 3, 2022
@olemartinorg olemartinorg deleted the chore/moving-jsonschema branch November 3, 2022 08:58
This was referenced Nov 3, 2022
Closed
Closed
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjosttveit bjosttveit bjosttveit approved these changes

@Magnusrm Magnusrm Magnusrm approved these changes

@tjololo tjololo Awaiting requested review from tjololo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move the layout schema(s) to this repo