Additional fix for validation of hidden fields in non-repeating groups #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 6, 2022 12:34
lorang92
approved these changes
May 9, 2022
|
Well, that failing test right after merging #84 was embarrassing... 🙈 I'll look into it again! |
Oh no! 🙃 In my experience, If Jeeva has reported something as a bug it has a tendency to be an actual bug and not a faulty test. It might be worthwhile to investigate if this is actually a weakness in our current code. |
|
Kudos, SonarCloud Quality Gate passed!
|
olemartinorg
pushed a commit
that referenced
this pull request
Nov 2, 2022
…amp for date picker component (#82) The implementation actually defaults to 'undefined', and there is a strict check if the timestamp is set to 'false'. The result of this check (timestamp === false) will only be true if timestamp is 'false'. 'undefined' (default) will not result in this check evaluating to 'true'.
1 task
This was referenced Jan 15, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The last fix (#69) didn't account for the other way to reproduce this issue; by hiding the fields themselves, even though they are defined in a group that could be hidden instead. With this fix both variants work as expected.
Fixes
Verification
Documentation