Skip to content

Technical debt: noImplicitAny #557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
olemartinorg opened this issue Oct 18, 2022 · 0 comments
Open

Technical debt: noImplicitAny #557

olemartinorg opened this issue Oct 18, 2022 · 0 comments

Comments

@olemartinorg
Copy link
Contributor

Description

Working in a TypeScript codebase is fantastic, and it really shines when using strict typing for everything, as you can be fairly confident when refactoring. I've spent full days refactoring strictly-typed TypeScript codebases, and everything worked on the first try as soon as the type-checker had no more errors to report. We should aim towards stricter type-checking to increase confidence when making changes to our codebase.

This issue speficially includes the work needed to set noImplicitAny to true in tsconfig.json. Setting this to true currently exposes 261 errors in main, most of which are easy to fix. Implicit any is usually caused by failing inferred types, which in turn is caused by overly lax typing on our end.

Also consider denying explicit any, making the project very strict (but hardened).

Related issues

@olemartinorg olemartinorg moved this to 📈 Todo in Team Apps Oct 18, 2022
@bjosttveit bjosttveit self-assigned this Oct 26, 2022
@bjosttveit bjosttveit moved this from 📈 Todo to 👷 In Progress in Team Apps Oct 26, 2022
@bjosttveit bjosttveit moved this from 👷 In Progress to ⚠️ Blocked in Team Apps Oct 26, 2022
@bjosttveit bjosttveit removed their assignment Oct 26, 2022
@olemartinorg olemartinorg moved this from ⚠️ Blocked to 📈 Todo in Team Apps Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 📈 Todo
Development

No branches or pull requests

2 participants