Skip to content

Technical debt: Enable null-checks in TypeScript #556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
olemartinorg opened this issue Oct 18, 2022 · 0 comments · Fixed by #597
Closed

Technical debt: Enable null-checks in TypeScript #556

olemartinorg opened this issue Oct 18, 2022 · 0 comments · Fixed by #597

Comments

@olemartinorg
Copy link
Contributor

Description

We currently have "strictNullChecks": false in our tsconfig.json, which lets us write dangerous code that never checks for types/properties that could be nullable/undefined. This issue alone has lead to multiple hard crashes/TypeErrors in production code this year alone. Setting this value to true causes 954 errors in the main branch right now, but cleaning these up is mostly a menial chore rather than something that requires acute attention to detail.

Prefer to do this at a point in time when there is less activity in the repo than usual.

Related issues

@olemartinorg olemartinorg moved this to 📈 Todo in Team Apps Oct 18, 2022
This was referenced Oct 18, 2022
@olemartinorg olemartinorg self-assigned this Oct 24, 2022
@olemartinorg olemartinorg moved this from 📈 Todo to 👷 In Progress in Team Apps Oct 25, 2022
@olemartinorg olemartinorg linked a pull request Nov 1, 2022 that will close this issue
3 tasks
@olemartinorg olemartinorg moved this from 👷 In Progress to 🔎 Review in Team Apps Nov 1, 2022
@olemartinorg olemartinorg removed their assignment Nov 1, 2022
Repository owner moved this from 🔎 Review to ✅ Done in Team Apps Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant