Strict null-checks #597
Merged
Strict null-checks #597
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
November 1, 2022 11:04
…LibCheck as default)
…not set in the preload state. Some failed because of my sloppy fixes.
…f null to categorize/group attachments. Luckily this was tested with Cypress!
github-actions
bot
added
area/attachments
area/instantiation
area/language
olemartinorg
added
quality/debt
and removed
area/attachments
area/instantiation
area/language
github-actions
bot
added
area/attachments
area/instantiation
area/language
olemartinorg
removed
area/attachments
area/instantiation
area/language
|
SonarCloud Quality Gate failed. |
Magnusrm
approved these changes
Nov 2, 2022
5 tasks
olemartinorg
added
kind/bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR enables strict null-checks in TypeScript, and makes sure all (currently) nullable values are properly checked. There should probably be some more nullable values, since the entire codebase has been written without strict null checks (so nullability was implicit everywhere until now). This is messy and suboptimal in many ways, but it's a step in the right direction where future changes are now much less likely to throw unexpected errors on values that are null/undefined.
Related Issue(s)
Verification
[ ] Relevant automated test added (if you find this hard, leave it and we'll help out)Documentation
[ ] User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)