Skip to content

Using dynamic options in page make it crash when going back to formfilling #511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
TheTechArch opened this issue Oct 2, 2022 · 4 comments
Assignees
Labels
kind/bug Something isn't working org/brg Issues relevant for Brønnøysundregistrene.

Comments

@TheTechArch
Copy link
Member

Description of the bug

In relle rettigheshavere we use dynamic options (disabled now). When it is enabled for the kontroll størrelse option it crashes when returning to Data task from confirmation. The options provider is not called

altinn-app-frontend.js:2

   TypeError: Cannot read properties of undefined (reading 'index')
at t.getIndexCombinations (altinn-app-frontend.js:2:2053084)
at altinn-app-frontend.js:2:2075576
at Array.forEach (<anonymous>)
at t.getOptionLookupKeys (altinn-app-frontend.js:2:2075463)
at d (altinn-app-frontend.js:2:2017417)
at d.next (<anonymous>)
at m (altinn-app-frontend.js:2:1697323)
at l (altinn-app-frontend.js:2:1697655)
at altinn-app-frontend.js:2:1693835
at g (altinn-app-frontend.js:2:1690101)

Steps To Reproduce

Enable dynamic options for this field.
Fill ot form
Go to confirm
Go back to data

See commit to disable
https://altinn.studio/repos/brg/rrh-innrapportering/commit/e228ecfee1f4f0bb1d070bdab256ff5f1ccd73ff

Additional Information

No response

@TheTechArch TheTechArch added kind/bug Something isn't working status/triage org/brg Issues relevant for Brønnøysundregistrene. labels Oct 2, 2022
@RonnyB71 RonnyB71 moved this to 👷 In Progress in Team Apps Oct 20, 2022
@olemartinorg olemartinorg moved this from 👷 In Progress to 🧪 Test in Team Apps Oct 21, 2022
@olemartinorg
Copy link
Contributor

I suspect this has been fixed now, as a consequence of #575 and #576. @TheTechArch, could you re-test this with v3.54.0-alpha2? I've made some attempts to reproduce it now, but I haven't managed to do it (but I'm unsure if I used the app correctly).

@allinox
Copy link
Contributor

allinox commented Oct 25, 2022

@olemartinorg
I tested this just now - seems to me like it works 😊

@olemartinorg
Copy link
Contributor

@allinox Fantastic! Sadly, the fix is a bit risky - and along with the #540 PR, the next release is scheduled to have a lot of (risky) changes. I'm wanting to delay it until I can look over #556 and clean up a little as well. You'll hear from me soon!

@olemartinorg olemartinorg moved this from 🧪 Test to ✅ Done in Team Apps Oct 27, 2022
@olemartinorg
Copy link
Contributor

Closing as it is tested OK, but my point about the delayed release remains.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working org/brg Issues relevant for Brønnøysundregistrene.
Projects
Archived in project
Development

No branches or pull requests

4 participants