Skip to content

fix to make sure page doesn't crash #518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

nkylstad
Copy link
Member

@nkylstad nkylstad commented Oct 5, 2022

Description

Add a check for empty repeating groups to avoid page crashing if repeating groups are not loaded before options start fetching - this is relevant when app uses dynamic options with mapping to field in repeating group. This also only happens when going TO a data task (using dynamic options w/mapping) FROM a confirmation task. Have not tested going FROM other task types, although it might be a problem then to 🤷‍♀️

The root issue still needs to be fixed

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

33.3% 33.3% Coverage
0.0% 0.0% Duplication

@olemartinorg
Copy link
Contributor

I think this can be closed now, as #511 looks to been fixed via #575 and #576. 🥳

@olemartinorg olemartinorg deleted the bug/511-dynamic-options branch November 2, 2022 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants