Expressions #540
Merged
Expressions #540
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
July 29, 2022 19:26
…ry simple DSL (parsed using regex)
…s (at least when used as constants, not when in argument expressions)
…f feels like I'm making a calculator app.
… hackaton/dynamics branch. Fixing some bugs in them, adjusting them to new typings, writing unit tests.
…tNode object on top (to be able to use closest() to find nodes on the top level), I found that it would be better to keep control inside the LayoutRootNode so we can use that for lookups, etc. Rewriting to return LayoutRootNode instead of a list of components.
…nd/or baseComponentId
1. Fixing implementation to take start/stop indexes into account 2. Fixing implementation of getRepeatingGroupStartStopIndex() to work properly when repeating group index is undefined (i.e. when there are no rows in the group). 3. Making the type from flat() smarter, depending on if groups are returned or just plain components 4. Implementing parents() and isHidden(), now used in validation.ts 5. Removing the old version of this code in validation.ts and replacing it with nodesInLayout(). The dataModelBindings are now correctly set in the recursive functions, so no need to pass on `groupDataBinding` and `index` any longer.
… or DSL expression
…n control the edit.addButton boolean value using a layout expression looking up a plain value in the data model. Lots of stuff left (I added a few TODOs). This is touching GroupContainer.tsx fairly lightly, resolving the 'container.edit' object using 'useLayoutExpressions'. Implementing LayoutRootNodeCollection to make it easier to work with multiple layouts.
…n here just returns the input, but this can be used to lookup values from dataModel/component/etc)
…'m supposed to call it). I started implementing this before we had a meeting today, where one of the points brought up was that we might want app developers to specify the index placeholders (like in textResourceBindings wih variables) instead, possibly making this redundant.
# Conflicts: # src/altinn-app-frontend/src/utils/validation/validation.ts
…g type-support for providing components with resolved layout expressions
… and 'true', my equals function failed without this.
…ponent (at least with simpleBinding).
…sionContext.ts class (which I'll add to in order to implement proper error messages when expressions fail to validate)
… looking up values (that are called the same way as other functions). This is a large step forwards in being able to support proper recursive expressions. Quite a few error test cases missing now, along with pretty error messages when an expression fails during validation and/or runtime evaluation.
Magnusrm
approved these changes
Oct 21, 2022
# Conflicts: # src/altinn-app-frontend/src/features/form/containers/GroupContainer.tsx # src/altinn-app-frontend/src/features/form/containers/RepeatingGroupTable.tsx
|
This pull request fixes 1 alert when merging 9fd63c8 into 2c413a1 - view on LGTM.com fixed alerts:
|
This was referenced Oct 24, 2022
…when conditionalRendering fetched the state before it had been set correctly
|
This pull request fixes 1 alert when merging 082634e into 03184e4 - view on LGTM.com fixed alerts:
|
added 5 commits
October 25, 2022 11:49
…icate objects failed to preserve the rowIndex value, which in turn caused a cypress test to fail(!). Yay for cypress!
…using start/stop indexes. This caused the likert.js cypress test to fail, as the rowIndex was fetched from the array index in the `rows` property, leading to the wrong language keys being fetched. Again, thank goodness for the cypress tests!
…nce context selector was not memoized
…ix did not account for direct usage of useExpressions() failing to memoize.
github-actions
bot
added
area/language
|
This pull request fixes 1 alert when merging 7dae397 into 21b496b - view on LGTM.com fixed alerts:
|
|
SonarCloud Quality Gate failed. |
This was referenced Oct 31, 2022
This was referenced Nov 7, 2022
olemartinorg
added
the
kind/product-feature
This was referenced Nov 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for dynamic expressions, as used in the following component properties:
requiredreadOnlyhidden(new!)edit.addButton(for repeating groups)edit.saveButton(for repeating groups)edit.deleteButton(for repeating groups)edit.saveAndNextButton(for repeating groups)Along with the following properties for layouts/pages:
hidden(new!) This makes it an alternative to tracks.It includes the following expression functions for now:
equals/notEqualsgreaterThan/greaterThanEq/lessThan/lessThanEqconcatand/orif(beta!) - else branch is optionally passed in with parametersinstanceContextfrontendSettingscomponent(resolves upwards inside repeating groups)dataModel(resolves its position inside repeating groups without the need for position placeholders)Try this out using the test app: https://dev.altinn.studio/repos/olemartinorg/layout-expressions
Because of the size of this PR, we'll do a review meeting instead of performing code review inside github. Marking this as draft until that meeting is over.
Related Issue(s)
Verification
Documentation
[ ] User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)