Skip to content

Expressions: Hide the edit button for repeating group rows #582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
olemartinorg opened this issue Oct 24, 2022 · 4 comments · Fixed by #1120
Closed

Expressions: Hide the edit button for repeating group rows #582

olemartinorg opened this issue Oct 24, 2022 · 4 comments · Fixed by #1120
Assignees
Labels
area/logic related to logic/dynamics/expressions kind/feature-request New feature or request org/brg Issues relevant for Brønnøysundregistrene. org/pat Issues relevant for Patentstyret org/ssb Issues relevant for Statistisk sentralbyrå.

Comments

@olemartinorg
Copy link
Contributor

Description

In the expressions implementation (#540), it is now possible to hide the addButton, saveButton and deleteButton for a repeating group. It should also be possible to hide the edit button this way, and have the expression evaluate per-row so that each row can decide to have their edit button hidden on their own.

Additional Information

@olemartinorg olemartinorg added kind/feature-request New feature or request area/logic related to logic/dynamics/expressions labels Oct 24, 2022
@olemartinorg olemartinorg moved this to 📈 Todo in Team Apps Oct 24, 2022
@StianVestli
Copy link

org/ssb

@olemartinorg olemartinorg added the org/ssb Issues relevant for Statistisk sentralbyrå. label Oct 27, 2022
@olemartinorg olemartinorg moved this to Todo in Issues SSB Nov 2, 2022
@olemartinorg olemartinorg moved this from Todo to In Progress in Issues SSB Nov 2, 2022
@olemartinorg
Copy link
Contributor Author

@Magnusrm This should be easy now, after #61 and #64, right? 🙏 Up for grabs if you want it!

@Magnusrm
Copy link
Contributor

@olemartinorg I can definitely pick this up. 😄
I imagine the expression part is already done, I guess this is mostly a matter of finding a good way to display different combos of edit and delete buttons in the rows. Ex: one row with only delete button and one with only edit button and one with no buttons. I imagine the header columns to be a bit tricky to handle with the current implementation, we might need to create a "action" column instead of "edit-button" and "delete-button" columns.

We might also need UX to decide how we want to display the different combos.

@olemartinorg
Copy link
Contributor Author

@Magnusrm Great point! Tagging @Febakke and @mrosvik. I think we just implement this short-term, but possibly reconsider the design in the long term.

@FinnurO FinnurO moved this to Backlog in Design Altinn 3 Jan 6, 2023
@olemartinorg olemartinorg moved this from In Progress to Todo in Issues SSB Jan 9, 2023
@bjosttveit bjosttveit added the org/pat Issues relevant for Patentstyret label Jan 16, 2023
@FinnurO FinnurO added the org/brg Issues relevant for Brønnøysundregistrene. label Jan 19, 2023
@olemartinorg olemartinorg self-assigned this Apr 19, 2023
@olemartinorg olemartinorg moved this from 📈 Todo to 👷 In Progress in Team Apps Apr 19, 2023
@olemartinorg olemartinorg moved this from 👷 In Progress to ⚠️ Blocked in Team Apps Apr 25, 2023
@olemartinorg olemartinorg moved this from ⚠️ Blocked to 👷 In Progress in Team Apps Apr 26, 2023
@olemartinorg olemartinorg moved this from 👷 In Progress to 🔎 Review in Team Apps Apr 26, 2023
@github-project-automation github-project-automation bot moved this from Todo to Done in Issues SSB Apr 27, 2023
@github-project-automation github-project-automation bot moved this to Ready for dev in Design Altinn 3 Apr 27, 2023
@framitdavid framitdavid moved this from 🔎 Review to 🧪 Test in Team Apps Apr 28, 2023
@lassopicasso lassopicasso moved this from 🧪 Test to ✅ Done in Team Apps May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/logic related to logic/dynamics/expressions kind/feature-request New feature or request org/brg Issues relevant for Brønnøysundregistrene. org/pat Issues relevant for Patentstyret org/ssb Issues relevant for Statistisk sentralbyrå.
Projects
Archived in project
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants