Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cypress-tests for Map component #813

Open
4 tasks
olemartinorg opened this issue Jan 4, 2023 · 1 comment
Open
4 tasks

Add Cypress-tests for Map component #813

olemartinorg opened this issue Jan 4, 2023 · 1 comment

Comments

@olemartinorg
Copy link
Contributor

olemartinorg commented Jan 4, 2023

Description

The Map component works, and is used in apps. Still, there are no cypress tests for it, so functionality in the component might stop working at some point if something should break. We've already had issues with a change in the design system that threatened to break the image marker in the Map component, but that potential breakage was stopped before it had any damaging effects.

Additional Information

Tasks

  • Test clicking a point in the map, and that it puts some data into the data model
  • Test dragging the map one 'world' over, and that the coordinates wrap
  • Test that image loading is successful for the marker icon (and the shadow/retina file)
  • Test the summary view for the component
@bjosttveit
Copy link
Member

We should maybe consider moving the Map component from altinn-design-system into this repo to make it easier to maintain dependencies (leaflet) and the implementation of our specific functionality. Is this component even used anywhere but app-frontend-react?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

2 participants