Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design system v0.25.13 with map component changes #807

Merged
merged 2 commits into from
Jan 3, 2023

Conversation

olemartinorg
Copy link
Contributor

Description

When upgrading the design system to v0.25.13, because of Altinn/altinn-design-system#250, some changes are needed to the map component for it to still load images (such as the marker icon).

These changes are needed in order for the design system to be easier to use for others, such as OED (as they don't need the map component, and they don't want to have to support bundling .png image files in their webpack configuration just for that component which they don't need).

Related Issue(s)

Verification

  • Manual testing
    • I have tested these changes manually
    • Creator of the original issue (or service owner) has been contacted for manual testing
    • No testing done/necessary
  • Automated tests
    • Unit test(s) have been added
    • Cypress E2E test(s) have been added
    • No automatic tests are needed here
    • I want someone to help me make some tests
  • User documentation @ altinn-studio-docs
    • Has been updated
    • No changes/updates needed
  • Changes/additions to component properties
    • Changes are reflected in both src/layout/layout.d.ts and layout.schema.v1.json, and these are all backwards-compatible
    • No changes made
  • Support in Altinn Studio
    • Issue(s) created for support in Studio
    • This change/feature does not require any changes to Altinn Studio
  • Sprint board
    • The original issue (or this PR itself) has been added to the Team Apps project and to the current sprint board

Ole Martin Handeland added 2 commits January 3, 2023 11:44
@olemartinorg olemartinorg added the kind/dependencies Pull requests that update a dependency file label Jan 3, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

Copy link
Contributor

@Magnusrm Magnusrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🗺️

@olemartinorg
Copy link
Contributor Author

Merging! The failing cypress test will be fixed by one of the later changes to #800.

@olemartinorg olemartinorg merged commit 1941e80 into main Jan 3, 2023
@olemartinorg olemartinorg deleted the chore/map-with-new-ds branch January 3, 2023 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/dependencies Pull requests that update a dependency file
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants