-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moving some code around #1055
Merged
Merged
Moving some code around #1055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… hooks, and no other files in common, so they can have their own top-level folder.
olemartinorg
added
kind/other
Pull requests containing chores/repo structure/other changes
ignore-for-release
Pull requests to be ignored in release notes
labels
Mar 27, 2023
olemartinorg
requested review from
bjosttveit,
framitdavid,
lassopicasso and
Magnusrm
March 27, 2023 16:12
…tore" This reverts commit da3d7cd.
This reverts commit a95ac7a.
…ers/* to src/features/wrappers (dropping dataLists, as that's causing trouble)
…it comes before 'src/features/form' in the import order. This happens because of some dependency that causes formDataSlice.ts and formLayoutSlice.ts not to load it correctly. Renaming the whole thing to just 'lists' mitigates the problem.
…ndex.ts` into `src/redux` (along with `src/utils/sagaSlice.ts`)
bjosttveit
approved these changes
Mar 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bjosttveit Great point! I didn't go that deeply into it, but I agree with you 100%. I'll check. |
# Conflicts: # src/layout/FileUploadWithTag/EditWindowComponent.tsx
…mports have been resolved, thus getting rid of the need to import code in the 'correct' order for our app to work. This now starts running the app on DOMContentLoaded.
… be initialized once first
…e of import order requirements (now that they are gone)
framitdavid
approved these changes
Mar 30, 2023
…ten after every initialization
21 tasks
SonarCloud Quality Gate failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ignore-for-release
Pull requests to be ignored in release notes
kind/other
Pull requests containing chores/repo structure/other changes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a low-priority PR (conflicts should be reduced before merging this). I'm continuing the ongoing repo and code cleanup by moving some files and code around - in order to hopefully make a more meaningful structure.
In summary:
LayoutNode
,LayoutPage
,LayoutPages
andLayoutObect
classes has been moved into their own respective source files (out fromhierarchy.ts
).src/hooks
instead of a combination ofsrc/common/hooks
andsrc/components/hooks
.src/shared
. Most files, fromsrc/shared/resources
has been moved intosrc/features
, where their most closely resembling counterparts reside in the newer repo structure. These 'resources' mostly contain sagas to load app content into the redux store.src/sagas
,src/reducers
andsrc/store
intosrc/redux
. (To reduce the number of small top-level folders, and all of these belong to store/state initialization).Later additions:
src/features
), thanks to suggestion by @bjosttveit.index.tsx
so that practically no code starts running until the JS file has been evaluated and all imports are resolved.Related Issue(s)
Verification/QA
src/layout/layout.d.ts
andlayout.schema.v1.json
, and these are all backwards-compatiblekind/*
label to this PR for proper release notes grouping