Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strict typing for textResourceBindings and dataModelBindings #1315

Merged
merged 8 commits into from
Jul 7, 2023
Merged

Strict typing for textResourceBindings and dataModelBindings #1315

merged 8 commits into from
Jul 7, 2023

Conversation

olemartinorg
Copy link
Contributor

Description

Each component now defines which data model binding type it expects, and every key in textResourceBindings needs to be defined in the component config before being referenced.

Related Issue(s)

Verification/QA

  • Manual functionality testing
    • I have tested these changes manually
    • Creator of the original issue (or service owner) has been contacted for manual testing (or will be contacted when released in alpha)
    • No testing done/necessary
  • Automated tests
    • Unit test(s) have been added/updated
    • Cypress E2E test(s) have been added/updated
    • No automatic tests are needed here (no functional changes/additions)
    • I want someone to help me make some tests
  • UU/WCAG (follow these guidelines until we have our own)
    • I have tested with a screen reader/keyboard navigation/automated wcag validator
    • No testing done/necessary (no DOM/visual changes)
    • I want someone to help me perform accessibility testing
  • User documentation @ altinn-studio-docs
    • Has been added/updated
    • No functionality has been changed/added, so no documentation is needed
    • I will do that later/have created an issue
  • Changes/additions to component properties
  • Support in Altinn Studio
    • Issue(s) created for support in Studio
    • This change/feature does not require any changes to Altinn Studio
  • Sprint board
    • The original issue (or this PR itself) has been added to the Team Apps project and to the current sprint board
    • I don't have permissions to do that, please help me out
  • Labels
    • I have added a kind/* label to this PR for proper release notes grouping
    • I don't have permissions to add labels, please help me out

Ole Martin Handeland added 7 commits July 5, 2023 15:38
Implementing support for concrete text resource bindings, strictly typed
68d679c
Fixing resolving of expressions in text resources for repeating group…
42c62b5 
… components, as this broken when I moved them out from the item itself
Fixing the node inspector
382126c
Updating comments that were left on TODO. Turns out AddressComponent …
2c952b2 
…hasn't supported a 'title' as far back as I could test it. Even our own frontend-test sets that, so I'm unsure if it's just because Studio enforces it.
Moving the data model bindings, valid text resources, and whether the…
1715942 
… label should be rendered or not, to the component definition
Rolling back to having textResourceBindings and dataModelBindings on …
447cd99 
…the items directly, now that it mostly works. Some places I had to cast types to make it work
Fixing merge mistake, making diffs easier to read by restructuring co…
eabc116 
…de back to the way it was
@olemartinorg olemartinorg added kind/other Pull requests containing chores/repo structure/other changes ignore-for-release Pull requests to be ignored in release notes labels Jul 6, 2023
@olemartinorg olemartinorg self-assigned this Jul 6, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 11 Code Smells

73.2% 73.2% Coverage
0.0% 0.0% Duplication

bjosttveit
bjosttveit approved these changes Jul 7, 2023
View reviewed changes
Copy link
Member

@bjosttveit bjosttveit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@olemartinorg olemartinorg merged commit b2892e6 into main Jul 7, 2023
@olemartinorg olemartinorg deleted the chore/textResourceBinding-unions branch July 7, 2023 08:06
@olemartinorg olemartinorg mentioned this pull request Aug 24, 2023
Merged
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjosttveit bjosttveit bjosttveit approved these changes

@Magnusrm Magnusrm Awaiting requested review from Magnusrm

@lassopicasso lassopicasso Awaiting requested review from lassopicasso

Assignees

@olemartinorg olemartinorg

Labels
ignore-for-release Pull requests to be ignored in release notes kind/other Pull requests containing chores/repo structure/other changes
Projects
Team Apps
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@olemartinorg @bjosttveit