Usegetoptions and data lists to hooks using tanstack #1442
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a-lists-to-hooks-using-tanstack
…https://github.com/Altinn/app-frontend-react into usegetoptions-and-data-lists-to-hooks-using-tanstack
… global state not being available. This should clean up and simplify the state in useAllOptions.tsx and fixes the problem.
…d yet, we saved a list of no nodes, meaning all options were loaded every time. This should delay the 'nodesFound' event until we have actually found nodes.
added 7 commits
September 27, 2023 13:44
…e receipt page/archived task type
…tanstack # Conflicts: # src/queries/queries.ts
…ed mapped options after preselectedOptionIndex (so that they appear in summary)
…Type(). Only data tasks are expected to generate nodes, and for non-data tasks we should say we found no nodes, and there are thus no options to fetch.
…use infinite loading/spinner, as it just did (before we fixed it by checking the current task type)
|
@lassopicasso Tests pass! 🥳 Time to write a description here about the whole ordeal, and open up for review.. 😁 |
added 2 commits
September 27, 2023 16:12
…ed by Percy, so as to make sure it's not flaky
… until it finds the value
lassopicasso
added
quality/debt
kind/other
|
SonarCloud Quality Gate failed.
|
|
Not sure what happened there with the Percy screenshots - the close button is now also shown on the receipt page for some reason, but it wasn't before. IMO, the close button should probably be shown there, so I think it's all OK. |
lassopicasso
deleted the
usegetoptions-and-data-lists-to-hooks-using-tanstack
branch
|
PDF tests are still passing 🥳 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this task @Magnusrm and I have collaborated to improve the functionality of two hooks,
useGetOptionsanduseDataLists, in order to reduce their dependence on Redux states. Our primary objective was to implement Tanstack Queries for fetching data within components using these hooks. This change will also allow us to eliminate some redundant Saga code.I would like to extend a special thanks to @olemartinorg for his invaluable contributions and significant involvement in realizing this project! ❤️
I’ve tried to summarized of what this PR introduces, but there’s a possibility I may have overlooked certain points. So, if there’s anything unclear in the code, feel free to point it out.
Changes to useGetOptions
useGetOptionsQuery, solely responsible for fetching options.useGetOptionshook, expanding its functionality to include support for static options and options (source) from repeating groups.preselectedOptionIndexand options changes from the components to the reusableuseGetOptionshook. We also introduced new functionality inuseRemoveStaleValuesto retain options that still exists when options have changed.Changes to useDataLists
useGetDataListQuery, solely responsible for fetching options.useDataListshook as there is for now no need for an intermediate layer between the component and useDataListQuery.These enhancements aim to streamline the use of these hooks and reduce their reliance on Redux states, ultimately improving the efficiency and maintainability of the codebase.
Unit and cypress tests
We’ve made significant updates to unit tests, addressing issues where they previously relied on options being available immediately without the need for fetching.
Furthermore, we have introduced new test cases to ensure everything works as planned, such as including handling options in dynamic scenarios (useRemoveStaleValues), resolved flakiness issues, and tested other behaviors that could result in failed tests following the implementation of Tanstack Query. These tests ensure the robustness of our code changes.
Related Issue(s)
useGetOptions()and data lists to hooks using Tanstack Query without Redux #1294Verification/QA
kind/*label to this PR for proper release notes grouping