Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove processActions feature flag #1516

Merged
merged 2 commits into from
Sep 28, 2023
Merged

Remove processActions feature flag #1516

merged 2 commits into from
Sep 28, 2023

Conversation

bjosttveit
Copy link
Member

@bjosttveit bjosttveit commented Sep 27, 2023

Description

This is another static feature flag that is hardcoded in the backend to allow backwards compatibillity with older versions of app-lib. Assuming that v4 requires v8 of app-lib, we can get rid of this featureflag and simplify some logic.

Altinn/app-lib-dotnet#205

@bjosttveit bjosttveit added quality/debt kind/breaking-change Issue/pull request containing a breaking change labels Sep 27, 2023
@bjosttveit bjosttveit self-assigned this Sep 27, 2023
@bjosttveit
Copy link
Member Author

bjosttveit commented Sep 27, 2023

Setting as draft. This requires test-apps to be updated to v8 for cypress tests to pass.

@bjosttveit bjosttveit marked this pull request as draft September 27, 2023 08:02
@olemartinorg olemartinorg removed their request for review September 27, 2023 09:04
Copy link
Contributor

@olemartinorg olemartinorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, but ping me again if you make any changes after upgrading the test-apps. 🚀

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

52.9% 52.9% Coverage
0.0% 0.0% Duplication

@bjosttveit
Copy link
Member Author

Code looks good, but ping me again if you make any changes after upgrading the test-apps. 🚀

All good 👍

@bjosttveit bjosttveit marked this pull request as ready for review September 28, 2023 11:20
@bjosttveit bjosttveit merged commit f1d4ac5 into main Sep 28, 2023
@bjosttveit bjosttveit deleted the remove-permission-flag branch September 28, 2023 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/breaking-change Issue/pull request containing a breaking change quality/debt
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants