Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documents to Sign List #2830

Merged
merged 11 commits into from
Jan 7, 2025
Merged

Documents to Sign List #2830

merged 11 commits into from
Jan 7, 2025

Conversation

cammiida
Copy link
Contributor

@cammiida cammiida commented Dec 18, 2024

Description

A list over documents to sign in signing.
Should only work in a signing task and only show documents that are configured to be signed in process.bpmn.
E.g.

<altinn:signatureConfig>
  <altinn:dataTypesToSign>
    <altinn:dataType>ref-data-as-pdf</altinn:dataType>
  </altinn:dataTypesToSign>
  <altinn:signatureDataType>signatures-founders</altinn:signatureDataType>
  <altinn:signeeStatesDataTypeId>signeeStates-founders</altinn:signeeStatesDataTypeId>
  <altinn:signeeProviderId>founders</altinn:signeeProviderId>
<altinn:signatureConfig>

image

Related Issue(s)

Verification/QA

  • Manual functionality testing
    • I have tested these changes manually
    • Creator of the original issue (or service owner) has been contacted for manual testing (or will be contacted when released in alpha)
    • No testing done/necessary
  • Automated tests
    • Unit test(s) have been added/updated
    • Cypress E2E test(s) have been added/updated
    • No automatic tests are needed here (no functional changes/additions)
    • I want someone to help me make some tests
  • UU/WCAG (follow these guidelines until we have our own)
    • I have tested with a screen reader/keyboard navigation/automated wcag validator
    • No testing done/necessary (no DOM/visual changes)
    • I want someone to help me perform accessibility testing
  • User documentation @ altinn-studio-docs
    • Has been added/updated
    • No functionality has been changed/added, so no documentation is needed
    • I will do that later/have created an issue
  • Support in Altinn Studio
    • Issue(s) created for support in Studio
    • This change/feature does not require any changes to Altinn Studio
  • Sprint board
    • The original issue (or this PR itself) has been added to the Team Apps project and to the current sprint board
    • I don't have permissions to do that, please help me out
  • Labels
    • I have added a kind/* label to this PR for proper release notes grouping
    • I don't have permissions to add labels, please help me out

@cammiida cammiida added the kind/feature-request New feature or request label Dec 18, 2024
@cammiida cammiida self-assigned this Dec 18, 2024
@cammiida cammiida added kind/product-feature Pull requests containing new features and removed kind/feature-request New feature or request labels Dec 18, 2024
@cammiida cammiida force-pushed the feature/signee-list branch 2 times, most recently from 646b5f4 to 66136dd Compare December 19, 2024 19:08
@cammiida cammiida force-pushed the feature/docs-to-sign-list branch from 8ccbac5 to 3cf6ec6 Compare December 19, 2024 20:00
@cammiida cammiida force-pushed the feature/docs-to-sign-list branch from 0851fdf to 002471b Compare January 3, 2025 13:42
Copy link
Member

@bjosttveit bjosttveit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just have some minor comments

Base automatically changed from feature/signee-list to feature/signing January 6, 2025 12:52
@cammiida cammiida force-pushed the feature/docs-to-sign-list branch from 002471b to 1aaeadc Compare January 6, 2025 14:08
@cammiida cammiida force-pushed the feature/docs-to-sign-list branch from 1aaeadc to 3c51d92 Compare January 6, 2025 14:32
Copy link

sonarqubecloud bot commented Jan 6, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
8.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@cammiida cammiida merged commit 8972a85 into feature/signing Jan 7, 2025
14 of 15 checks passed
@cammiida cammiida deleted the feature/docs-to-sign-list branch January 7, 2025 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/product-feature Pull requests containing new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants