add datamodelbinding for surname for personlookup #2866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HauklandJ
added
kind/product-feature
cammiida
approved these changes
Jan 6, 2025
| setValue('person_lookup_ssn', data.person.ssn); | ||
| } | ||
| } | ||
|
|
||
| function getFullName({ firstName, middleName, lastName }) { | ||
| return middleName ? `${firstName} ${middleName} ${lastName}` : `${firstName} ${lastName}`; |
There was a problem hiding this comment.
Trenger ikke endre på det nå, bare et tips i tilfelle det kan bli handy en gang du har et litt mer komplekst case enn her og du ikke har sett det før 😄
Jeg syns det ofte er nice å legge sammen tekst vha en liste. Typ
[firstName, middleName, lastName].filter(it != null).join(" ")
| @@ -29,7 +29,7 @@ export const Config = new CG.component({ | |||
| new CG.prop( | |||
| 'person_lookup_name', | |||
| new CG.dataModelBinding() | |||
| .setTitle('Data model binding for zip code') | |||
| .setTitle('Data model binding for the full name of a person') | |||
Co-authored-by: Camilla Marie Dalan <camillamdalan@gmail.com>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue(s)
Verification/QA
kind/*label to this PR for proper release notes grouping