Skip to content

Feat/additional dataflags in datepicker #3090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

walldenfilippa
Copy link
Contributor

@walldenfilippa walldenfilippa commented Mar 5, 2025

Description

Added yesterday, tomorrow, one year from now and one year ago as dataflags for property minDate and maxDate in Datepicker.

Note: If the date is February 29th, the one year ago option will shift to March 1st when using Typescript/setFullYear. However, when using C#/getYear, it will automatically adjust to February 28th (this is not the case here).

Related Issue(s)

Verification/QA

  • Manual functionality testing
    • I have tested these changes manually
    • Creator of the original issue (or service owner) has been contacted for manual testing (or will be contacted when released in alpha)
    • No testing done/necessary
  • Automated tests
    • Unit test(s) have been added/updated
    • Cypress E2E test(s) have been added/updated
    • No automatic tests are needed here (no functional changes/additions)
    • I want someone to help me make some tests
  • UU/WCAG (follow these guidelines until we have our own)
    • I have tested with a screen reader/keyboard navigation/automated wcag validator
    • No testing done/necessary (no DOM/visual changes)
    • I want someone to help me perform accessibility testing
  • User documentation @ altinn-studio-docs
    • Has been added/updated
    • No functionality has been changed/added, so no documentation is needed
    • I will do that later/have created an issue
  • Support in Altinn Studio
    • Issue(s) created for support in Studio
    • This change/feature does not require any changes to Altinn Studio
  • Sprint board
    • The original issue (or this PR itself) has been added to the Team Apps project and to the current sprint board
    • I don't have permissions to do that, please help me out
  • Labels
    • I have added a kind/* label to this PR for proper release notes grouping
    • I don't have permissions to add labels, please help me out

Sorry, something went wrong.

@olemartinorg olemartinorg added kind/product-feature Pull requests containing new features backport-ignore This PR is a new feature and should not be cherry-picked onto release branches labels Apr 23, 2025
Copy link
Contributor

@olemartinorg olemartinorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry this took so long to review! I see the unit tests are failing here, can you double-check them? Try running yarn test dateHelpers

Also, can you make a PR for the docs for this component? 🙏

@olemartinorg olemartinorg moved this to 🔎 Review in Team Apps Apr 23, 2025
@olemartinorg olemartinorg self-assigned this Apr 23, 2025
@olemartinorg olemartinorg moved this from 🔎 Review to 👷 In Progress in Team Apps Apr 24, 2025
…neYearFromNow
@olemartinorg olemartinorg merged commit 80c8b76 into Altinn:main May 8, 2025
6 of 7 checks passed
@github-project-automation github-project-automation bot moved this from 👷 In Progress to 🧪 Test in Team Apps May 8, 2025
@HanneLauritsen1967 HanneLauritsen1967 moved this from 🧪 Test to ✅ Done in Team Apps May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-ignore This PR is a new feature and should not be cherry-picked onto release branches kind/product-feature Pull requests containing new features
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants