Enabling redux devtools in production

[olemartinorg]

Description

This change enables redux devtools in the production build, which brings with a few hundred bytes extra code, as well as a 7.1mb altinn-app-frontend.js.map and a 556kb altinn-app-frontend.css.map to be published on altinncdn.no.

Adding these to the production build gives us a few advantages when debugging and reproducing strange bugs:

• We can record the redux state history, saving them to a file, making it possible to save and replay the state history for race condition bugs
• Thrown exceptions in our own code will include references to the actual source files, lines and code that caused the error (instead of line 1, column 489984)

Related Issue(s)

• Expose redux devtools in production #392
• Race condition leading to text resources not loading #452

Verification

• Your code builds clean without any errors or warnings
• Manual testing done (required)
• [ ] Relevant automated test added (if you find this hard, leave it and we'll help out)
• All tests run green

Documentation

• User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)
  • Adding docs for debugging frontend altinn-studio-docs#665

[olemartinorg]

I spoke with @lorang92 and @altinnadmin about this, and we decided against the 7mb source map this time around. Having it checked into the git repo for cdn, hosted on github spaces, etc, would quickly balloon into much more disk usage than just 7mb.

We also considered:

• Hosting the source maps elsewhere
• Only copying over the source map for the major version to CDN (skipping source maps inside every minor/patch folder)
• Gzipping (1.8mb) or compressing with brotli (1.4mb), however it seems devtools are not ready for a .js.map.gz or .js.map.br yet - it didn't load correctly (might have been an issue with the wrong HTTP response headers being generated by my static file web server).

TL;DR: Skipping source maps for now

[lorang92]

Just a note: this defaults to true, so strictly not needed config. But better to be explicit I guess!

Neat 🥇

[olemartinorg]

Oh, didn't know that! But yeah, I don't mind that being explicit.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[ivarne]

How expensive are those sourcemaps really? They won't be downloaded unless people open devtools. With the current state of react frontend crashing for every error in the json files, it would really help to speed up our debugging process to figure out what is wrong.

[olemartinorg]

@ivarne I agree they would be useful, especially for more experienced developers, but as of now they might be problematic to add to the CDN. As the CDN is backed by a git repo, every new file needs to be checked into git, grows the history, and might affect our ability to serve the CDN at all (github static pages have storage limitations). I'm hoping for this to easier in the future, possibly after moving the CDN to azure. Right now, the risks outweighs the benefits, IMO.