Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing inconsistent prev/next navigation buttons #657

Closed
wants to merge 4 commits into from

Conversation

olemartinorg
Copy link
Contributor

Description

I've observed that the previous/next navigation buttons sometimes mysteriously disappeared, and I was about to create a bug report for it. However, to figure out if it was just my config that was wrong, I looked into it and quickly found the cause behind the problem - these buttons seem to somewhat rely on a navigation property set in the layout file (which is an undocumented feature?!). I'm a bit confused about what was supposed to happen here, so I'm opening a draft PR to get some feedback. These changes seems to work in the same way the documentation describes, though.

Related

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

…xt one even if navigationConfig is not set/configured
@olemartinorg
Copy link
Contributor Author

Still not sure about this one. I think I have to go sift through the code to fully understand how these things are expected to interact with implicitly added submit button(s), etc.

@olemartinorg olemartinorg self-assigned this Nov 17, 2022
@RonnyB71
Copy link
Member

RonnyB71 commented Dec 5, 2022

Potential breaking change. Will be merged when we introduce V4 of App Frontend.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

91.3% 91.3% Coverage
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants