Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add methods in IData interface that does not take HttpRequest as input #228

Closed
tjololo opened this issue Apr 14, 2023 · 0 comments · Fixed by #231
Closed

Add methods in IData interface that does not take HttpRequest as input #228

tjololo opened this issue Apr 14, 2023 · 0 comments · Fixed by #231
Assignees
@tjololo
Labels
kind/feature-request New feature or request

Comments

@tjololo
Copy link
Member

tjololo commented Apr 14, 2023

Description

IData.UpdateBinaryData takes HttpRequest with the binary data as input, we should remove the need for passing the HttpRequest down from controllers and only require the data we actually need to store the data.

The data we currently extract from the HttpRequest today seems to be filename and content type.

This would make the controller responsible for extracting the parts from the httprequest and as a side effect make it much easier to use the IData service to insert and update data in storage.

Old methods requiring httprequest should me marked as deprecated and remove in an later major release

Additional Information

  • Create new methods where only methods with HttpRequest as input paramas exists
  • Deprecate and move away from using the old methods
@tjololo tjololo mentioned this issue Apr 14, 2023
Closed
@tjololo tjololo self-assigned this Apr 14, 2023
@tjololo tjololo moved this to 👷 In Progress in Team Apps Apr 14, 2023
@tjololo tjololo mentioned this issue Apr 18, 2023
Merged
5 tasks
@tjololo tjololo moved this from 👷 In Progress to 🔎 Review in Team Apps Apr 18, 2023
tjololo added a commit that referenced this issue Apr 24, 2023
@tjololo
Introduce new method in IData for updating BinaryData (#228) (#231)
2cecad6 
* Introduce new method in IData for updating BinaryData without a HttpRequest as input. Old method marked as obsolete

* Consolidate test classes and replace JwtTokenUtil with UserTokenProvider

* Fix build errors

* Add some more tests and fix nullability warnings
@tjololo tjololo moved this from 🔎 Review to 🧪 Test in Team Apps Apr 24, 2023
@tjololo tjololo moved this from 🧪 Test to ✅ Done in Team Apps Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tjololo tjololo

Labels
kind/feature-request New feature or request
Projects
Team Apps
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Introduce new method in IData for updating BinaryData (#228) Altinn/app-lib-dotnet
1 participant
@tjololo