Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark Correspondence client and responses as Experimental #1059

Merged
merged 5 commits into from
Jan 23, 2025
Merged

Mark Correspondence client and responses as Experimental #1059

merged 5 commits into from
Jan 23, 2025

Conversation

danielskovli
Copy link
Contributor

@danielskovli danielskovli commented Jan 23, 2025 •
edited
Loading

Description

Since the Correspondence API has not yet stabilised, this patch marks the client + methods, along with their responses as experimental. The request objects are not annotated, because we are not expecting any breaking changes to the input for the Correspondence API.

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@danielskovli danielskovli changed the title Let the experiment begin Mark CorrespondenceClient and method _outputs_ as Experimental Jan 23, 2025
@danielskovli danielskovli changed the title Mark CorrespondenceClient and method _outputs_ as Experimental Mark CorrespondenceClient and method *outputs* as Experimental Jan 23, 2025
@danielskovli danielskovli changed the title Mark CorrespondenceClient and method *outputs* as Experimental Mark CorrespondenceClient and responses as Experimental Jan 23, 2025
@danielskovli danielskovli marked this pull request as ready for review January 23, 2025 14:11
@ivarne ivarne added the other A PR that should be in release notes, but as a chore label Jan 23, 2025
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@danielskovli danielskovli changed the title Mark CorrespondenceClient and responses as Experimental Mark Correspondence client and responses as Experimental Jan 23, 2025
@danielskovli danielskovli merged commit 319ef01 into main Jan 23, 2025
15 of 16 checks passed
@danielskovli danielskovli deleted the chore/correspondence-experimental-attrs branch January 23, 2025 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinothamar martinothamar martinothamar approved these changes

Assignees
No one assigned
Labels
other A PR that should be in release notes, but as a chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danielskovli @martinothamar @ivarne