Ensure that ValidationIssue.Field respects [JsonPropertyName]

[ivarne]

When there is a mismatch between the C# property name and the [JsonPropertyName()]

And one of the nested [System.ComponentModel.DataAnnotations] rules fails, the Field property of ValidationIssue is wrong, and frontend can't attach the error to the correct component.

Description

Some xsd definitions contain property names with illegal characters that can't be used in properties (without ugly escaping)

To solve that conflict, additional properties is added for json and xml serialziation to include the illegal characters. This needs to be respected everywhere.

In net70, this is easily fixed with a configuration change, https://learn.microsoft.com/en-us/aspnet/core/mvc/models/validation?view=aspnetcore-7.0#use-json-property-names-in-validation-errors, but in net60, we need to manually translate the keys.

Related Issue(s)

• not sure if this has previously been reported.

Verification

• Your code builds clean without any errors or warnings
• Manual testing done (required)
• Relevant automated test added (if you find this hard, leave it and we'll help out)
• All tests run green

Documentation

• User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

[tjololo]

We should change the signature of MapModelStateToIssueList to only require the Type of the data object as we don't need anything else in the method

[ivarne]

@tjololo Totally agree ❤️
I just initially thought the logic would be dependent on the value, not just the type, and then I fixed it for only one level up.

[tjololo]

Looks good 👍