Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/10108 remove shadow fields #233

Merged
merged 7 commits into from
May 15, 2023
Merged

Feature/10108 remove shadow fields #233

merged 7 commits into from
May 15, 2023

Conversation

nkylstad
Copy link
Member

@nkylstad nkylstad commented Apr 26, 2023 •
edited
Loading

Description

Add support for removing shadow fields OnEndProcessTask.

  • Uses a configurable prefix on the data model fields to determine which fields to remove.
  • Allows for configuration of whether data element should be updated directly or if a copy (where shadow fields are removed) should be created.

Related Issue(s)

Related PRs

The code will not work until this PR is merged and updated nuget published

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

tjololo
tjololo reviewed May 3, 2023
View reviewed changes
Copy link
Member

@tjololo tjololo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, is there any chance of adding some tests?

src/Altinn.App.Core/Helpers/ShadowFieldsConverter.cs Outdated Show resolved Hide resolved
@nkylstad nkylstad marked this pull request as ready for review May 10, 2023 06:25
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 9 Code Smells

97.7% 97.7% Coverage
0.0% 0.0% Duplication

@tjololo tjololo merged commit 588555a into main May 15, 2023
@tjololo tjololo deleted the feature/10108-remove-shadow-fields branch May 15, 2023 11:29
@tjololo tjololo added the feature Label Pull requests with new features. Used when generation releasenotes label May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjololo tjololo tjololo approved these changes

Assignees
No one assigned
Labels
feature Label Pull requests with new features. Used when generation releasenotes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nkylstad @tjololo