#192 Support for expressions in BPMN gateways #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+123
to
+130
| catch (Exception e) | ||
| { | ||
| using var jsonDocument = JsonDocument.Parse(data); | ||
|
|
||
| testCase.Name = jsonDocument.RootElement.GetProperty("name").GetString(); | ||
| testCase.ExpectsFailure = jsonDocument.RootElement.TryGetProperty("expectsFailure", out var expectsFailure) ? expectsFailure.GetString() : null; | ||
| testCase.ParsingException = e; | ||
| } |
Check notice
Code scanning / CodeQL
Generic catch clause
Comment on lines
+69
to
+75
| if(outgoingFlows.Any(a => a.ConditionExpression != null)) | ||
| { | ||
| gatewayFilter = _gatewayFactory.GetProcessExclusiveGateway("AltinnExpressionsExclusiveGateway"); | ||
| } else | ||
| { | ||
| gatewayFilter = _gatewayFactory.GetProcessExclusiveGateway(directFlowTarget.Id); | ||
| } |
Check notice
Code scanning / CodeQL
Missed ternary opportunity
RonnyB71
reviewed
Jun 1, 2023
RonnyB71
reviewed
Jun 1, 2023
src/Altinn.App.Core/Internal/Process/ExpressionsExclusiveGateway.cs
Outdated
Show resolved
Hide resolved
RonnyB71
reviewed
Jun 1, 2023
| return layoutSet; | ||
| } | ||
|
|
||
| private async Task<(string? DataTypeId, Type? DataTypeClassType)> GetDataType(Instance instance, LayoutSet? layoutSet, string? dataTypeId) |
There was a problem hiding this comment.
This logic seems to belong elsewhere, but we're perhaps missing the natural place to place it. Unless we use similar methods in other parts of the code we should make a note of it and figure out where it should be until next time.
There was a problem hiding this comment.
Couldn't find a natural home, I will add a TODO comment stating that we should find a home for it
|
Kudos, SonarCloud Quality Gate passed! |
tjololo
added a commit
that referenced
this pull request
Jun 1, 2023
* Working gateway filter leveraging expressions to make decisions * remove logger * Add tests for expressions function gatewayAction * move test out of shared tests as it is only supported backend (no process in frontend) * Add tests and small refactoring * Fix code smells * Fixes after review
tjololo
added
the
feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support for expressions in process gateways.
This extends the expression code with a function for getting the action performed in the task leading up to the gateway.
By default the dataModel in the expression context is set to the task before the gateway, but it is possible to override what DataType the expression context should be connected to in a gateway by setting connectedDataTypeId in the extensionelements in the BPMN file.
This fixes #192
Related Issue(s)
Verification
Documentation