Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/signing delegation #982

Merged
merged 44 commits into from
Jan 3, 2025
Merged

Feature/signing delegation #982

merged 44 commits into from
Jan 3, 2025

Conversation

HauklandJ
Copy link
Contributor

@HauklandJ HauklandJ commented Dec 16, 2024 •
edited
Loading

Description

Related Issue(s)

  • #{issue number}

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@HauklandJ HauklandJ self-assigned this Dec 16, 2024
@HauklandJ HauklandJ added area/signing feature Label Pull requests with new features. Used when generation releasenotes labels Dec 16, 2024
@HauklandJ
Copy link
Contributor Author

/publish

@github-actions GitHub Actions
Copy link

Published PR packages:

@HauklandJ
Copy link
Contributor Author

/publish

@github-actions GitHub Actions
Copy link

Published PR packages:

@HauklandJ
Copy link
Contributor Author

/publish

@github-actions GitHub Actions
Copy link

Published PR packages:

@HauklandJ
Copy link
Contributor Author

/publish

@github-actions GitHub Actions
Copy link

Published PR packages:

@HauklandJ
Copy link
Contributor Author

/publish

@github-actions GitHub Actions
Copy link

Published PR packages:

@HauklandJ
Copy link
Contributor Author

/publish

@github-actions GitHub Actions
Copy link

Published PR packages:

@HauklandJ
Copy link
Contributor Author

/publish

@github-actions GitHub Actions
Copy link

Published PR packages:

@github-actions GitHub Actions
Copy link

Published PR packages:

@HauklandJ
Copy link
Contributor Author

/publish

@github-actions GitHub Actions
Copy link

Published PR packages:

@HauklandJ
Copy link
Contributor Author

/publish

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 2, 2025

Published PR packages:

@HauklandJ
Copy link
Contributor Author

/publish

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 2, 2025

Published PR packages:

@HauklandJ HauklandJ requested a review from bjorntore January 2, 2025 14:25
bjorntore
bjorntore approved these changes Jan 3, 2025
View reviewed changes
Copy link
Contributor

@bjorntore bjorntore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking forward to trying it out in TT02!

src/Altinn.App.Core/Features/Signing/SigningService.cs Outdated Show resolved Hide resolved
src/Altinn.App.Core/Features/Signing/SigningService.cs Outdated Show resolved Hide resolved
@HauklandJ
Copy link
Contributor Author

Looking forward to trying it out in TT02!

Feel free to try at your leisure: https://ttd.apps.tt02.altinn.no/ttd/signering-brukerstyrt

cammiida
cammiida approved these changes Jan 3, 2025
View reviewed changes
Copy link
Contributor

@cammiida cammiida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

src/Altinn.App.Core/Features/Telemetry/Telemetry.SigningService.cs Outdated Show resolved Hide resolved
src/Altinn.App.Core/Internal/AccessManagement/AccessManagementClient.cs Outdated Show resolved Hide resolved
src/Altinn.App.Core/Internal/AccessManagement/AccessManagementClient.cs Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 3, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
10.1% Coverage on New Code (required ≥ 65%)
14.0% Duplication on New Code (required ≤ 3%)
5.56% Condition Coverage on New Code (required ≥ 65%)

See analysis details on SonarQube Cloud

@HauklandJ HauklandJ merged commit a4426a1 into feature/signing Jan 3, 2025
9 of 10 checks passed
@HauklandJ HauklandJ deleted the feature/signing-delegation branch January 3, 2025 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cammiida cammiida cammiida approved these changes

@bjorntore bjorntore bjorntore approved these changes

Assignees

@HauklandJ HauklandJ

Labels
area/signing feature Label Pull requests with new features. Used when generation releasenotes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HauklandJ @bjorntore @cammiida