Skip to content

Commit

Permalink
fix: disable slack notifier (#1655)
Browse files Browse the repository at this point in the history
<!--- Provide a general summary of your changes in the Title above -->

## Description

<!--- Describe your changes in detail -->

The slack notifier is not working as expected atm and breaks the
infrastructure deployments. Also, we have gained access to a Grafana
instance and we can set up alerts there

## Related Issue(s)

- #1466 

## Verification

- [ ] **Your** code builds clean without any errors or warnings
- [ ] Manual testing done (required)
- [ ] Relevant automated test added (if you find this hard, leave it and
we'll help out)

## Documentation

- [ ] Documentation is updated (either in `docs`-directory, Altinnpedia
or a separate linked PR in
[altinn-studio-docs.](https://github.com/Altinn/altinn-studio-docs), if
applicable)
  • Loading branch information
arealmaas authored Jan 7, 2025
1 parent 4877c65 commit 554fc8b
Show file tree
Hide file tree
Showing 7 changed files with 0 additions and 293 deletions.
34 changes: 0 additions & 34 deletions .azure/infrastructure/main.bicep
Original file line number Diff line number Diff line change
Expand Up @@ -51,9 +51,6 @@ param appConfigurationSku AppConfigurationSku
import { Sku as AppInsightsSku } from '../modules/applicationInsights/create.bicep'
param appInsightsSku AppInsightsSku

import { Sku as SlackNotifierSku } from '../modules/functionApp/slackNotifier.bicep'
param slackNotifierSku SlackNotifierSku

import { Sku as PostgresSku } from '../modules/postgreSql/create.bicep'
import { StorageConfiguration as PostgresStorageConfig } from '../modules/postgreSql/create.bicep'

Expand Down Expand Up @@ -262,19 +259,6 @@ module copyEnvironmentSecrets '../modules/keyvault/copySecrets.bicep' = {
}
}

module slackNotifier '../modules/functionApp/slackNotifier.bicep' = {
name: 'slackNotifier'
scope: resourceGroup
params: {
location: location
keyVaultName: environmentKeyVault.outputs.name
namePrefix: namePrefix
applicationInsightsName: appInsights.outputs.appInsightsName
sku: slackNotifierSku
tags: tags
}
}

module containerAppIdentity '../modules/managedIdentity/main.bicep' = {
scope: resourceGroup
name: 'containerAppIdentity'
Expand All @@ -299,15 +283,6 @@ module containerAppEnv '../modules/containerAppEnv/main.bicep' = {
}
}

module appInsightsReaderAccessPolicy '../modules/applicationInsights/addReaderRoles.bicep' = {
scope: resourceGroup
name: 'appInsightsReaderAccessPolicy'
params: {
appInsightsName: appInsights.outputs.appInsightsName
principalIds: [slackNotifier.outputs.functionAppPrincipalId]
}
}

module postgresConnectionStringAppConfig '../modules/appConfiguration/upsertKeyValue.bicep' = {
scope: resourceGroup
name: 'AppConfig_Add_DialogDbConnectionString'
Expand All @@ -332,15 +307,6 @@ module redisConnectionStringAppConfig '../modules/appConfiguration/upsertKeyValu
}
}

module keyVaultReaderAccessPolicy '../modules/keyvault/addReaderRoles.bicep' = {
scope: resourceGroup
name: 'keyVaultReaderAccessPolicyFunctions'
params: {
keyvaultName: environmentKeyVault.outputs.name
principalIds: [slackNotifier.outputs.functionAppPrincipalId]
}
}

output resourceGroupName string = resourceGroup.name
output containerAppEnvId string = containerAppEnv.outputs.containerAppEnvId
output environmentKeyVaultName string = environmentKeyVault.outputs.name
5 changes: 0 additions & 5 deletions .azure/infrastructure/prod.bicepparam
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,6 @@ param appConfigurationSku = {
param appInsightsSku = {
name: 'PerGB2018'
}
param slackNotifierSku = {
storageAccountName: 'Standard_LRS'
applicationServicePlanName: 'Y1'
applicationServicePlanTier: 'Dynamic'
}
param postgresConfiguration = {
sku: {
name: 'Standard_D8ads_v5'
Expand Down
5 changes: 0 additions & 5 deletions .azure/infrastructure/staging.bicepparam
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,6 @@ param appConfigurationSku = {
param appInsightsSku = {
name: 'PerGB2018'
}
param slackNotifierSku = {
storageAccountName: 'Standard_LRS'
applicationServicePlanName: 'Y1'
applicationServicePlanTier: 'Dynamic'
}
param postgresConfiguration = {
sku: {
name: 'Standard_D4ads_v5'
Expand Down
5 changes: 0 additions & 5 deletions .azure/infrastructure/test.bicepparam
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,6 @@ param appConfigurationSku = {
param appInsightsSku = {
name: 'PerGB2018'
}
param slackNotifierSku = {
storageAccountName: 'Standard_LRS'
applicationServicePlanName: 'Y1'
applicationServicePlanTier: 'Dynamic'
}
param postgresConfiguration = {
sku: {
name: 'Standard_B2s'
Expand Down
5 changes: 0 additions & 5 deletions .azure/infrastructure/yt01.bicepparam
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,6 @@ param appConfigurationSku = {
param appInsightsSku = {
name: 'PerGB2018'
}
param slackNotifierSku = {
storageAccountName: 'Standard_LRS'
applicationServicePlanName: 'Y1'
applicationServicePlanTier: 'Dynamic'
}
param postgresConfiguration = {
sku: {
name: 'Standard_D8ads_v5'
Expand Down
18 changes: 0 additions & 18 deletions .azure/modules/functionApp/appSettings.bicep

This file was deleted.

221 changes: 0 additions & 221 deletions .azure/modules/functionApp/slackNotifier.bicep

This file was deleted.

0 comments on commit 554fc8b

Please sign in to comment.