Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise dialog statuses #1084

Closed
3 tasks done
elsand opened this issue Sep 5, 2024 · 0 comments
Closed
3 tasks done

Revise dialog statuses #1084

elsand opened this issue Sep 5, 2024 · 0 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@elsand
Copy link
Member

elsand commented Sep 5, 2024

Introduction

This clarifies the distinct statuses on dialogs.

Description

The new statuses should be:
New
Draft
InProgress
Sent
RequiresAttention
Completed

"Processing" is renamed to "Sent" (same semantics),
"Signing" is removed,
"Draft" is added (should only be used to indicate user-initiated dialogs not yet sent)

Implementation

If there are guidelines on architecture or other implementation choices, they are added here. Different approaches can also be discussed here.

Tasks

Preview Give feedback

Threat modelling

Preview Give feedback
@elsand elsand added the good first issue Good for newcomers label Sep 5, 2024
@elsand elsand changed the title Revise dialog statues Revise dialog statuses Sep 5, 2024
@Fargekritt Fargekritt self-assigned this Sep 9, 2024
Fargekritt added a commit that referenced this issue Sep 9, 2024
## Description
Revised DialogStatus
* Renamed Processing -> Sent
* Removed signing
* Added Draft
## Related Issue(s)

[#1084](#1084)

## Verification

- [x] **Your** code builds clean without any errors or warnings
- [x] Manual testing done (required)
- [ ] Relevant automated test added (if you find this hard, leave it and
we'll help out)

## Documentation

- [ ] Documentation is updated (either in `docs`-directory, Altinnpedia
or a separate linked PR in
[altinn-studio-docs.](https://github.com/Altinn/altinn-studio-docs), if
applicable)

---------

Co-authored-by: Amund Myrbostad <amund.myrbostad@digdir.no>
Fargekritt added a commit that referenced this issue Sep 9, 2024
## Description

Fixed k6 tests to work with new dialog status

## Related Issue(s)

[#1084](#1084)

## Verification

- [x] **Your** code builds clean without any errors or warnings
- [x] Manual testing done (required)
- [ ] Relevant automated test added (if you find this hard, leave it and
we'll help out)

## Documentation

- [ ] Documentation is updated (either in `docs`-directory, Altinnpedia
or a separate linked PR in
[altinn-studio-docs.](https://github.com/Altinn/altinn-studio-docs), if
applicable)

Co-authored-by: Amund Myrbostad <amund.myrbostad@digdir.no>
@elsand elsand closed this as completed Sep 12, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Good first issues Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants