Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Legge på ExternalReference i svaret fra GET /api/v1/serviceowner/dialogs #1376

Closed
prange opened this issue Nov 1, 2024 · 3 comments
Closed

Legge på ExternalReference i svaret fra GET /api/v1/serviceowner/dialogs #1376

prange opened this issue Nov 1, 2024 · 3 comments
Assignees
@oskogstad

Comments

@prange
Copy link

prange commented Nov 1, 2024

Introduction

Vi ønsker at externalReference settes på en item i svaret når vi søker opp dialoger

Description

Vi har en frontend som lister opp aktive dialoger mellom en aktør og dmf. For å knytte dialogene opp mot konkrete engasjement bruker vi externalReference for å knytte opp en dialog mot et konkret engasjement. (se #1157 (comment)_). Vi har tenkt å laste inn alle aktuelle dialoger og så flette de sammen med engasjementene, men det går ikke da externalReference ikke er inkludert i svaret. Alternativet blir da å gjøre et GET kall pr dialog kun for å hente det ene feltet.
@MagnusSandgren
Copy link
Collaborator

Enig i det du sier. Legger oppgaven til backlog.

@oskogstad oskogstad self-assigned this Nov 3, 2024
@oskogstad oskogstad mentioned this issue Nov 3, 2024
Merged
4 tasks
oskogstad added a commit that referenced this issue Nov 4, 2024
@oskogstad
feat(webapi): Add ExternalReference to dialog search result (#1384)
431fe16 
<!--- Provide a general summary of your changes in the Title above -->

## Description

<!--- Describe your changes in detail -->

## Related Issue(s)

- #1376 

## Verification

- [ ] **Your** code builds clean without any errors or warnings
- [ ] Manual testing done (required)
- [ ] Relevant automated test added (if you find this hard, leave it and
we'll help out)

## Documentation

- [ ] Documentation is updated (either in `docs`-directory, Altinnpedia
or a separate linked PR in
[altinn-studio-docs.](https://github.com/Altinn/altinn-studio-docs), if
applicable)


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Introduced an `externalReference` property in the dialog schema,
enhancing metadata for better integration with external systems.
- Added an `ExternalReference` property in the `DialogDtoBase` class for
service-specific references to external systems.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
@oskogstad
Copy link
Collaborator

ExternalReference skal vises i søk på tt02 nå

@LeifHelstad
Copy link

Testet i tt. Ny dialog av dagen "019353ff-e9bd-75fa-ab65-a521d873c4b1".
Både ved single- og multiselect så fremkommer "externalReference": "denEksterneReferansen" på dialogen.

@elsand elsand closed this as completed Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oskogstad oskogstad

Labels
None yet
Projects
Dialogporten / Arbeidsflate - NY
Status: Done
Milestone
No milestone
Development

No branches or pull requests
5 participants
@prange @elsand @MagnusSandgren @oskogstad @LeifHelstad