Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return 410 GONE for notification checks on deleted dialogs #1386

Closed
oskogstad opened this issue Nov 4, 2024 · 2 comments
Closed

Return 410 GONE for notification checks on deleted dialogs #1386

oskogstad opened this issue Nov 4, 2024 · 2 comments
Assignees
@oskogstad
Labels
bug Something isn't working

Comments

@oskogstad
Copy link
Collaborator

Description

Notification condition checks return 404 NOT FOUND for dialogs that are soft deleted.

Expected behavior

410 GONE

Actual behavior

404 NOT FOUND
@oskogstad oskogstad added the bug Something isn't working label Nov 4, 2024
@oskogstad oskogstad mentioned this issue Nov 4, 2024
Merged
4 tasks
oskogstad added a commit that referenced this issue Nov 4, 2024
@oskogstad
feat(webapi): Return 410 GONE for notification checks on deleted dial…
198bebd 
…ogs (#1387)

<!--- Provide a general summary of your changes in the Title above -->

## Description

<!--- Describe your changes in detail -->

## Related Issue(s)

- #1386 

## Verification

- [ ] **Your** code builds clean without any errors or warnings
- [ ] Manual testing done (required)
- [ ] Relevant automated test added (if you find this hard, leave it and
we'll help out)

## Documentation

- [ ] Documentation is updated (either in `docs`-directory, Altinnpedia
or a separate linked PR in
[altinn-studio-docs.](https://github.com/Altinn/altinn-studio-docs), if
applicable)


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Enhanced error handling for deleted entities in the notification
condition query.
- Added a new response type for deleted dialogs, improving clarity in
error reporting.

- **Bug Fixes**
- Improved response handling for scenarios where a requested dialog has
been deleted.

- **Tests**
- Introduced a new test case to verify correct behavior when querying a
deleted dialog.
	- Refactored test methods for improved readability and maintainability.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
@oskogstad oskogstad self-assigned this Nov 4, 2024
@LeifHelstad
Copy link

Test : Jeg har slettet dialogen først en gang og så igjen for å sjekke at den ikke kan slettes to ganger. Det er OK.
image

Likevel får jeg med samme id treff med GET som om dialogen ikke er slettet i det heletatt.
image

@LeifHelstad
Copy link

LeifHelstad commented Nov 21, 2024 •
edited
Loading

Tested OK (Da denne endringen går på notification og ikke dialogen i sin helhet.)

image

@elsand elsand closed this as completed Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oskogstad oskogstad

Labels
bug Something isn't working
Projects
Dialogporten / Arbeidsflate
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@elsand @oskogstad @LeifHelstad