Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary explicit NuGet references #1467

Open
oskogstad opened this issue Nov 14, 2024 · 0 comments
Open

Remove unnecessary explicit NuGet references #1467

oskogstad opened this issue Nov 14, 2024 · 0 comments
Labels
technical debt Issue detailing clean ups and needed refactorings

Comments

@oskogstad
Copy link
Collaborator

When upgrading to .NET9, we had to add some explicit references to packages that previously were implicit.
The ones referencing these were using old versions, and because of new analyzer updates in .NET9 we get warnings for vulnerabilities in these versions, and warnings are errors!

So we either had to disable <TreatWarningsAsErrors> or disable the warnings, both bad options.
The least bad option is to explicitly upgrade all of these NuGets.

They should be removed once the ones making the implicit references happen have updated their NuGets.

These Nugets:

  • System.Text.Json
  • System.Drawing.Common
  • Microsoft.IdentityModel.JsonWebTokens
  • System.IdentityModel.Tokens.Jwt
  • System.Formats.Asn1

in these projects:

  • Application Integration Tests
  • SlackNotifier
  • Utils AspNet
  • WebAPI
  • Infrastructure
  • CDC
@oskogstad oskogstad added the technical debt Issue detailing clean ups and needed refactorings label Nov 14, 2024
@oskogstad oskogstad changed the title Remove unused implicit NuGet references Remove unnecessary explicit NuGet references Jan 22, 2025
@oskogstad oskogstad moved this from Backlog to Doing in Dialogporten / Arbeidsflate - NY Jan 22, 2025
oskogstad added a commit that referenced this issue Jan 22, 2025
<!--- Provide a general summary of your changes in the Title above -->

## Description

<!--- Describe your changes in detail -->

## Related Issue(s)

- #1467 

## Verification

- [ ] **Your** code builds clean without any errors or warnings
- [ ] Manual testing done (required)
- [ ] Relevant automated test added (if you find this hard, leave it and
we'll help out)

## Documentation

- [ ] Documentation is updated (either in `docs`-directory, Altinnpedia
or a separate linked PR in
[altinn-studio-docs.](https://github.com/Altinn/altinn-studio-docs), if
applicable)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
technical debt Issue detailing clean ups and needed refactorings
Projects
Development

No branches or pull requests

1 participant