Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ContentValueDto has incorrect mediatype info (OpenAPI spec) #1613

Closed
oskogstad opened this issue Dec 16, 2024 · 3 comments
Closed

ContentValueDto has incorrect mediatype info (OpenAPI spec) #1613

oskogstad opened this issue Dec 16, 2024 · 3 comments
Assignees
@oskogstad
Labels
bug Something isn't working

Comments

@oskogstad
Copy link
Collaborator

Description

The OpenAPI spec shows incorrect mediatypes for content values,
every type across dialog/transmission says Media type of the content (plaintext, Markdown). Can also indicate that the content is embeddable.

Dialog

  • Title: text/plain
  • Summary: text/plain
  • SenderName: text/plain
  • ExtendedStatus: text/plain
  • AdditionalInfo: text/plain,text/markdown
  • MainContentRef: application/vnd.dialogporten.frontchannelembed+json;type=markdown

Transmission:

  • Title: text/plain
  • Summary: text/plain
  • ContentRef: application/vnd.dialogporten.frontchannelembed+json;type=markdown
@oskogstad oskogstad added the bug Something isn't working label Dec 16, 2024
@oskogstad oskogstad self-assigned this Dec 16, 2024
@oskogstad oskogstad mentioned this issue Dec 16, 2024
Merged
4 tasks
oskogstad added a commit that referenced this issue Dec 16, 2024
@oskogstad
chore(webapi): Remove specific mediatypes on ContentValueDto (#1614)
1f69b9b 
<!--- Provide a general summary of your changes in the Title above -->

## Description

<!--- Describe your changes in detail -->

## Related Issue(s)

- #1613

## Verification

- [ ] **Your** code builds clean without any errors or warnings
- [ ] Manual testing done (required)
- [ ] Relevant automated test added (if you find this hard, leave it and
we'll help out)

## Documentation

- [ ] Documentation is updated (either in `docs`-directory, Altinnpedia
or a separate linked PR in
[altinn-studio-docs.](https://github.com/Altinn/altinn-studio-docs), if
applicable)
@LeifHelstad
Copy link

@oskogstad hvor skal jeg kunne lese ut denne spesifikasjonen?
Følger: https://docs.altinn.studio/dialogporten/reference/openapi/
Hvis jeg følger lenkene til de ulike miljøene kommer jeg til "swagger definisjoner" som kun sier "string" for alle feltene som er listet i saken her.

@oskogstad
Copy link
Collaborator Author

@LeifHelstad string er selve typen ja, denne saken var ang. restriksjon på innholdet i stringen.
Det sto at text/plain og text/markdown var gyldig for alle, men det stemmer ikke.
Det står ingen plass i dokumentasjonen/swagger enda, står vel bare noe ala URL TBD

@LeifHelstad
Copy link

Test

Da oppfatter jeg dette som hele endringen:

Image

@elsand elsand moved this from Testing to Done in Dialogporten / Arbeidsflate - NY Jan 15, 2025
@elsand elsand closed this as completed by moving to Done in Dialogporten / Arbeidsflate - NY Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oskogstad oskogstad

Labels
bug Something isn't working
Projects
Dialogporten / Arbeidsflate - NY
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@elsand @oskogstad @LeifHelstad