EndUser Transmission endpoints does not mask unauthorized attachment URLs

[oskogstad]

Description

EndUser transmission endpoints gives out original URLs when the user is not authorized to see them

Reproduction

Create a transmission containing attachments, and with an authorization attribute you know the user does not have, not-authorized f.ex.
Fetch the dialog at api/v1/enduser/dialogs/{dialogId}, attachment URLs are all swapped out with our unauthorized URI.

Get the transmission via either single or list endpoint,
/api/v1/enduser/dialogs/{dialogId}/transmissions/{transmissionId}
and
/api/v1/enduser/dialogs/{dialogId}/transmissions

Expected behavior

URLs should be masked as urn:dialogporten:unauthorized

"urls": [
    {
        "id": "01950f63-abef-7131-8fd8-937ab93d523f",
        "url": "urn:dialogporten:unauthorized",
        "consumerType": "Gui"
    }
]

Actual behavior

Original URL is shown in both endpoints

"urls": [
    {
        "id": "01950f63-abef-7131-8fd8-937ab93d523f",
        "url": "https://digdir.apps.tt02.altinn.no/some-url",
        "consumerType": "Gui"
    }
]

[LeifHelstad]

Test

🟢 Har testet ut fra beskrivelsen i saken og det fungerer. URL-ene til vedleggene blir maskert.

Basert på dokumentasjonen https://docs.altinn.studio/dialogporten/reference/entities/transmission/ burde man for authorizationAttribute også kunne angitt en URN. Men her kan ikke avsender angi hva som helst, det er en URN-validering.

🟢 Test med en URN som org kan sende for, men som party her ikke kan åpne (muligens litt tilfeldig)