Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search allows filters with CreatedAfter greater than CreateBefore #2018

Open
oskogstad opened this issue Mar 6, 2025 · 2 comments
Open

Search allows filters with CreatedAfter greater than CreateBefore #2018

oskogstad opened this issue Mar 6, 2025 · 2 comments
Assignees
@oskogstad
Labels
bug Something isn't working

Comments

@oskogstad
Copy link
Collaborator

This will always result in no results, since it makes no sense.
We "AND" these together, and a dialog cannot be created after 2023 and before 2022.

This applies to all date fields that can be filtered for both ServiceOwner and EndUser

  • CreatedAt
  • DueAt
  • UpdatedAt
  • VisibleFrom (ServiceOwner only)
@oskogstad oskogstad added the bug Something isn't working label Mar 6, 2025
@oskogstad oskogstad moved this to Code Review og PR in Dialogporten / Arbeidsflate Mar 6, 2025
@oskogstad oskogstad self-assigned this Mar 6, 2025
@oskogstad oskogstad mentioned this issue Mar 6, 2025
Merged
4 tasks
oskogstad added a commit that referenced this issue Mar 7, 2025
@oskogstad
fix: Disallow search filter with CreatedAfter greater than CreatedBef…
75af11e 
…ore (#2019)

<!--- Provide a general summary of your changes in the Title above -->

## Description

This PR disallows search filtering with `{dateProperty}After >
{dateProperty}Before`
for all available date filter types, 

* CreatedAt
* DueAt
* UpdatedAt
* VisibleFrom (ServiceOwner only)

Also adding tests to verify these filters work with normal use, and that
validation errors are produced when the rule above is broken.

## Related Issue(s)

- #2018

## Verification

- [x] **Your** code builds clean without any errors or warnings
- [x] Manual testing done (required)
- [x] Relevant automated test added (if you find this hard, leave it and
we'll help out)

## Documentation

- [ ] Documentation is updated (either in `docs`-directory, Altinnpedia
or a separate linked PR in
[altinn-studio-docs.](https://github.com/Altinn/altinn-studio-docs), if
applicable)
@oskogstad oskogstad moved this from Code Review og PR to Testing in Dialogporten / Arbeidsflate Mar 7, 2025
@LeifHelstad
Copy link

LeifHelstad commented Mar 11, 2025 •
edited
Loading

Test

🟢 Å lage et søk på før en tidlig dato samtidig som etter en sen dato gir nå en feilmelding siden det aldri vil gi treff

EndUser + CreatedAt

Legger ved detaljert eksempel med to søk et med riktig og et med feil datointervall som eksempel.

CreatedAfter < CreatedBefore

Image

CreatedAfter > CreatedBefore

Image

EndUser + UpdatedAt

Image

OBS

Postman er kilen på blankspaces "UpdatedAfter " != "UpdatedAfter" selv om vist URL i begge tilfeller blir den samme:
/api/v1/enduser/dialogs?Party=urn:altinn:person:identifier-no:20815497741&UpdatedAfter=2025-03-10T13:04:09.159Z&UpdatedBefore=2025-03-09T06:04:09.159Z

@LeifHelstad
Copy link

Vi sperrer for opplagte feil, men likevel ikke logiske feil mellom datovarientene

Burde denne sperres for?

(Rettelsene gjelder for Before mot After innen hver enkelt datorange ikke på tvers av datoranges, så dette issuet er testet OK.)

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oskogstad oskogstad

Labels
bug Something isn't working
Projects
Dialogporten / Arbeidsflate
Status: Testing
Milestone
No milestone
Development

No branches or pull requests
2 participants
@oskogstad @LeifHelstad