Change cultureCode to languageCode #863
Assignees
Comments
oskogstad
moved this from Ready
to Doing
in ⚠️ Dialogporten / Arbeidsflate - GAMMEL - se https://github.com/orgs/Altinn/projects/146 ⚠️
4 tasks
oskogstad
moved this from Doing
to Code Review og PR
in ⚠️ Dialogporten / Arbeidsflate - GAMMEL - se https://github.com/orgs/Altinn/projects/146 ⚠️
oskogstad
added a commit
that referenced
this issue
Jul 1, 2024
<!--- Provide a general summary of your changes in the Title above --> ## Description <!--- Describe your changes in detail --> Renames CultureCode to LanguageCode Still supports culture code as input, but normalizes to neutral language codes. ## Related Issue(s) - #863 ## Verification - [ ] **Your** code builds clean without any errors or warnings - [ ] Manual testing done (required) - [ ] Relevant automated test added (if you find this hard, leave it and we'll help out) ## Documentation - [ ] Documentation is updated (either in `docs`-directory, Altinnpedia or a separate linked PR in [altinn-studio-docs.](https://github.com/Altinn/altinn-studio-docs), if applicable)
vildestixrud
moved this from Code Review og PR
to Testing / Design QA
in ⚠️ Dialogporten / Arbeidsflate - GAMMEL - se https://github.com/orgs/Altinn/projects/146 ⚠️
github-project-automation
bot
moved this from Testing / Design QA
to Done
in ⚠️ Dialogporten / Arbeidsflate - GAMMEL - se https://github.com/orgs/Altinn/projects/146 ⚠️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Introduction
Having support for anything but neutral cultures takes us far into YAGNI-land, so we change the name of "cultureCode" to "languageCode" and start normalizing inputs to culture-neutral two/three letter ISO-639 codes.
Description
See discussion on https://altinndevops.slack.com/archives/C06FTKW146B/p1715858314202269?thread_ts=1715770039.305999&cid=C06FTKW146B
We should continue to accept culture specific inputs (en_GB, en_US, en-GB, en-US), but should always normalize this (in the database) as a culture neutral code (ie. en).
This is a breaking change. There should not be made any attempts to convert existing data in the database.
Tasks
Threat modelling
Acceptance criteria
GIVEN a service owner creating a dialog with localization sets
WHEN a localization set contains a culture specifc language code (eg. "en_US" or "en-US")
THEN the code should be normalized to its culture neutral code (eg. "en") and stored as such in the database
The text was updated successfully, but these errors were encountered: