chore(graphql): Remove custom OTEL event listener #1797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📝 WalkthroughWalkthroughThis pull request removes the OpenTelemetry instrumentation setup for GraphQL requests. The class providing the instrumentation logic along with its related helper classes was deleted. Additionally, the service registration that previously added this diagnostic event listener has been removed from the GraphQL configuration extension method. Changes
Suggested reviewers
Tip 🌐 Web search-backed reviews and chat
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (2)
💤 Files with no reviewable changes (2)
⏰ Context from checks skipped due to timeout of 90000ms (2)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
knuhau
approved these changes
Feb 4, 2025
oskogstad
pushed a commit
that referenced
this pull request
Feb 5, 2025
🤖 I have created a release *beep* *boop* --- ## [1.48.3](v1.48.2...v1.48.3) (2025-02-05) ### Miscellaneous Chores * **deps:** bump vitest from 3.0.4 to 3.0.5 ([#1798](#1798)) ([7c306fd](7c306fd)) * **deps:** update bicep dependencies (major) ([#1621](#1621)) ([6fef560](6fef560)) * **deps:** update dotnet monorepo ([#1800](#1800)) ([0d08537](0d08537)) * **deps:** update masstransit monorepo to 8.3.5 ([#1801](#1801)) ([3f35e0f](3f35e0f)) * **graphql:** Remove custom OTEL event listener ([#1797](#1797)) ([56adb3f](56adb3f)) * **performance:** Adding breakpoint tests ([#1793](#1793)) ([fe93b20](fe93b20)) * Remove CDC and obsolete version property from docker compose ([#1796](#1796)) ([663734c](663734c)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This custom listener adds no new info, we have built in telemetry from HotChocolate