chore(k6): Consolidate k6-utils import URLs #1869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📝 WalkthroughWalkthroughThis pull request updates several JavaScript test files to replace external dependency URLs with local module paths. Specifically, the import and export statements for the Changes
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (9)
tests/k6/common/uuid.js(1 hunks)tests/k6/tests/enduser/performance/enduser-search.js(1 hunks)tests/k6/tests/graphql/performance/graphql-search.js(1 hunks)tests/k6/tests/performancetest_common/createDialog.js(1 hunks)tests/k6/tests/performancetest_common/simpleSearch.js(1 hunks)tests/k6/tests/scenarios/performance/create-dialog-and-search.js(1 hunks)tests/k6/tests/serviceowner/performance/createDialogBreakpoint.js(1 hunks)tests/k6/tests/serviceowner/performance/createTransmissionsBreakpoint.js(1 hunks)tests/k6/tests/serviceowner/performance/purge-dialogs.js(1 hunks)
✅ Files skipped from review due to trivial changes (6)
- tests/k6/tests/scenarios/performance/create-dialog-and-search.js
- tests/k6/tests/enduser/performance/enduser-search.js
- tests/k6/tests/performancetest_common/createDialog.js
- tests/k6/tests/performancetest_common/simpleSearch.js
- tests/k6/tests/serviceowner/performance/createDialogBreakpoint.js
- tests/k6/tests/serviceowner/performance/purge-dialogs.js
🔇 Additional comments (1)
tests/k6/tests/serviceowner/performance/createTransmissionsBreakpoint.js (1)
3-3: LGTM!The change from external URL to local path aligns with the PR objective and is consistent with the modifications in other files.
MagnusSandgren
approved these changes
Feb 13, 2025
oskogstad
pushed a commit
that referenced
this pull request
Feb 13, 2025
🤖 I have created a release *beep* *boop* --- ## [1.50.5](v1.50.4...v1.50.5) (2025-02-13) ### Miscellaneous Chores * **k6:** Consolidate k6-utils import URLs ([#1869](#1869)) ([09b3722](09b3722)) * Misc. formatting, typos ([#1868](#1868)) ([5de894f](5de894f)) * **performance:** Adjust thresholds ([#1870](#1870)) ([3e6e3b9](3e6e3b9)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.