chore(performance): tweaked thresholds

[dagfinno]

Description

Tweaked thresholds for create dialogs and transmissions

Related Issue(s)

• Adjust thresholds for CI smoke tests #1862

Verification

• Your code builds clean without any errors or warnings
• Manual testing done (required)
• Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

• Documentation is updated (either in docs-directory, Altinnpedia or a separate linked PR in altinn-studio-docs., if applicable)

[coderabbitai]

📝 Walkthrough

Walkthrough

This pull request updates the performance thresholds in two K6 test scripts. In both scripts, the threshold for the HTTP request duration for creating dialogs has been increased from 200 milliseconds to 300 milliseconds. In the transmissions test script, an additional threshold adjustment for creating transmissions has been changed from 200 milliseconds to 500 milliseconds. No other elements or public entity declarations were modified.

Changes

File(s)	Change Summary
tests/k6/.../createDialogWithThresholds.js	Increased the HTTP request duration threshold for the "create dialog" operation from 200 ms to 300 ms.
tests/k6/.../createTransmissionsWithThresholds.js	Increased the "create dialog" threshold from 200 ms to 300 ms and updated the "create transmission" threshold from 200 ms to 500 ms in the performance test configuration.

Possibly related PRs

• chore(performance): Adjust thresholds #1870: Modifies performance thresholds for both dialog and transmission creation tests, directly relating to the threshold adjustments.
• chore(performance): refactor generating tokens #1843: Updates thresholds in performance testing for the "create dialog" operation, aligning closely with these modifications.
• chore(performance):tweaking of thresholds and improvements on performance smoketest #1879: Focuses on increasing the HTTP request duration threshold for the "create dialog" operation, directly matching the changes made in these scripts.

Suggested labels

performance

Suggested reviewers

• oskogstad
• Fargekritt

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 33acb95 and c8da48a.

📒 Files selected for processing (2)

• tests/k6/tests/serviceowner/performance/createDialogWithThresholds.js (1 hunks)
• tests/k6/tests/serviceowner/performance/createTransmissionsWithThresholds.js (1 hunks)

🔇 Additional comments (3)

tests/k6/tests/serviceowner/performance/createDialogWithThresholds.js (1)

9-9: Verify the rationale for increasing the dialog creation threshold.

The threshold for dialog creation has been relaxed from 200ms to 300ms. While this aligns with the PR objectives and matches the threshold in createTransmissionsWithThresholds.js, please confirm:

1. What performance data led to this adjustment?
2. Is this a temporary or permanent change?

tests/k6/tests/serviceowner/performance/createTransmissionsWithThresholds.js (2)

10-10: LGTM! Dialog threshold matches createDialogWithThresholds.js.

The dialog creation threshold is consistently set to 300ms across both test files.

---

12-12: Verify the significant increase in transmission creation threshold.

The threshold for transmission creation has been substantially relaxed from 200ms to 500ms, which is a 150% increase. Please confirm:

1. What performance data justifies this larger adjustment?
2. Have you considered intermediate thresholds (e.g., 400ms)?
3. Could this indicate a need for performance optimization in the transmission creation process?

✨ Finishing Touches

• 📝 Generate Docstrings (Beta)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.