chore(e2etests): Fixing orgNos and resources to run tests in yt01

[dagfinno]

Description

Fixing orgNos and resources to match whats in yt01

Related Issue(s)

• Adjust thresholds for CI smoke tests #1862

Verification

• Your code builds clean without any errors or warnings
• Manual testing done (required)
• Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

• Documentation is updated (either in docs-directory, Altinnpedia or a separate linked PR in altinn-studio-docs., if applicable)

[coderabbitai]

📝 Walkthrough

Walkthrough

This pull request updates configuration constants in the K6 test suite to use dynamic values based on the __ENV.API_ENVIRONMENT variable. The changes include modifying an existing constant and adding new ones in tests/k6/common/config.js. Subsequent modifications in test files replace hardcoded values with these new configurable constants for organization numbers, resource names, and IDs, thereby aligning test configurations with the environment specified at runtime.

Changes

File(s)	Change Summary
tests/k6/common/config.js	Updated defaultServiceOwnerOrgNo to use a conditional value based on __ENV.API_ENVIRONMENT and added otherOrgNo, otherOrgName, otherServiceResource, and notValidEnduserId with environment-specific assignments.
tests/k6/tests/enduser/dialogDetails.js	Changed availableExternalResource from "urn:altinn:resource:app_digdir_be-om-api-nokkel" to "urn:altinn:resource:ttd-dialogporten-automated-tests-correspondence".
tests/k6/tests/serviceowner/dialogCreateIdempotentKey.js, tests/k6/tests/serviceowner/dialogSearch.js, tests/k6/tests/serviceowner/testdata/01-create-dialog.js	Replaced hardcoded configuration values with dynamic ones by importing constants from .../common/config.js; updated properties such as orgNo, orgName, serviceResource, actorId, and invalidEndUserId accordingly.

Possibly related PRs

• test: exclude threshold tests from all tests #1685: Involved modifications to constants in config.js that are used across various test files, similar to the changes in this PR.
• chore(performance):tweaking of thresholds and improvements on performance smoketest #1879: Addressed updates to organization numbers and service resources in K6 tests, directly relating to the dynamic configuration approach implemented here.
• chore(e2etests):  #1898: Made adjustments to exported constants in tests/k6/common/config.js, closely aligning with the introduction of new configuration values in this PR.

Suggested reviewers

• oskogstad
• arealmaas

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 322b1c9 and 5d7fc66.

📒 Files selected for processing (5)

• tests/k6/common/config.js (1 hunks)
• tests/k6/tests/enduser/dialogDetails.js (1 hunks)
• tests/k6/tests/serviceowner/dialogCreateIdempotentKey.js (2 hunks)
• tests/k6/tests/serviceowner/dialogSearch.js (2 hunks)
• tests/k6/tests/serviceowner/testdata/01-create-dialog.js (2 hunks)

🔇 Additional comments (6)

tests/k6/common/config.js (1)

43-47: LGTM! Environment-specific configuration values are well structured.

The configuration changes appropriately handle different environments by using conditional assignments based on __ENV.API_ENVIRONMENT. This makes the test suite more flexible and environment-aware.

tests/k6/tests/serviceowner/dialogCreateIdempotentKey.js (1)

3-3: LGTM! Test data properly utilizes the new configuration constants.

The changes correctly implement the dynamic configuration values, making the tests more maintainable and environment-aware.

Also applies to: 9-10, 31-32

tests/k6/tests/enduser/dialogDetails.js (1)

14-14: LGTM! Resource identifier updated to use test-specific value.

The availableExternalResource now correctly points to a test-specific resource, which is more appropriate for automated testing.

tests/k6/tests/serviceowner/dialogSearch.js (1)

25-25: LGTM! Invalid user ID test properly uses configuration constant.

The test now correctly utilizes the environment-aware notValidEnduserId configuration, making it more maintainable across different environments.

Also applies to: 207-207

tests/k6/tests/serviceowner/testdata/01-create-dialog.js (2)

3-3: LGTM! Import of configurable organization number.

The addition of defaultServiceOwnerOrgNo from the config file aligns with the PR objective of making organization numbers configurable based on the environment.

---

305-305: LGTM! Dynamic organization number in actorId.

The change from a hardcoded organization number to using defaultServiceOwnerOrgNo correctly maintains the URN format while making the value configurable based on the environment.

✨ Finishing Touches

• 📝 Generate Docstrings (Beta)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.