trivial: Misc. cleanup #1951
Merged
trivial: Misc. cleanup #1951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📝 WalkthroughWalkthroughThe pull request comprises several non-functional and minor functional adjustments. In the application code, unused import statements are removed, a new property is added to a dialog entity, and a constant replaces a hardcoded string. Additionally, the indentation of method calls is adjusted in query handlers. Multiple test and script files also receive extensive whitespace and formatting refinements, including comment cleanups, removal of extra blank lines, and export reordering. These changes do not alter the program’s behavior but improve consistency and readability. Changes
Suggested reviewers
✨ Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
tests/k6/common/dialog.js (1)
150-150: Fix indentation for consistency.The line uses 3 spaces for indentation while the rest of the file uses 4 spaces.
- throw new Error("Invalid systemLabel provided."); + throw new Error("Invalid systemLabel provided.");src/Digdir.Domain.Dialogporten.Domain/Dialogs/Entities/DialogEntity.cs (1)
49-51: Consider adding documentation to clarify the relationship.The relationship between
StatusIdandStatusproperties could benefit from XML documentation to explain their purpose and relationship.Add documentation to clarify:
// === Dependent relationships === + /// <summary> + /// The ID of the dialog's status. + /// </summary> public DialogStatus.Values StatusId { get; set; } + /// <summary> + /// The navigation property for the dialog's status. + /// </summary> public DialogStatus Status { get; set; } = null!;
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (32)
src/Digdir.Domain.Dialogporten.Application/Features/V1/EndUser/DialogSystemLabels/Commands/Set/SystemLabelCommand.cs(0 hunks)src/Digdir.Domain.Dialogporten.Application/Features/V1/EndUser/Dialogs/Queries/Search/SearchDialogQuery.cs(1 hunks)src/Digdir.Domain.Dialogporten.Application/Features/V1/ServiceOwner/Dialogs/Queries/Search/SearchDialogQuery.cs(1 hunks)src/Digdir.Domain.Dialogporten.Domain/Dialogs/Entities/DialogEntity.cs(1 hunks)src/Digdir.Library.Dialogporten.WebApiClient/ServiceCollectionExtensions.cs(3 hunks)src/Digdir.Library.Dialogporten.WebApiClient/Services/EdDsaSecurityKeysCacheService.cs(0 hunks)tests/k6/common/config.js(1 hunks)tests/k6/common/describe.js(3 hunks)tests/k6/common/dialog.js(3 hunks)tests/k6/common/extend.js(2 hunks)tests/k6/common/report.js(1 hunks)tests/k6/common/token.js(3 hunks)tests/k6/scripts/generate_all_tests.ps1(1 hunks)tests/k6/tests/enduser/performance/enduser-search.js(2 hunks)tests/k6/tests/graphql/performance/graphql-search.js(1 hunks)tests/k6/tests/performancetest_common/createDialog.js(6 hunks)tests/k6/tests/performancetest_common/getTokens.js(2 hunks)tests/k6/tests/performancetest_common/readTestdata.js(4 hunks)tests/k6/tests/performancetest_common/simpleSearch.js(7 hunks)tests/k6/tests/performancetest_data/01-create-dialog.js(3 hunks)tests/k6/tests/scenarios/performance/create-dialog-and-search.js(3 hunks)tests/k6/tests/serviceowner/dialogCreateIdempotentKey.js(1 hunks)tests/k6/tests/serviceowner/dialogCreateInvalidProcess.js(1 hunks)tests/k6/tests/serviceowner/performance/create-remove-dialog.js(2 hunks)tests/k6/tests/serviceowner/performance/create-transmissions.js(1 hunks)tests/k6/tests/serviceowner/performance/createDialogBreakpoint.js(2 hunks)tests/k6/tests/serviceowner/performance/createDialogWithThresholds.js(1 hunks)tests/k6/tests/serviceowner/performance/createTransmissionsBreakpoint.js(1 hunks)tests/k6/tests/serviceowner/performance/createTransmissionsWithThresholds.js(1 hunks)tests/k6/tests/serviceowner/performance/createremove-no-delay.js(1 hunks)tests/k6/tests/serviceowner/performance/purge-dialogs.js(6 hunks)tests/k6/tests/serviceowner/performance/serviceowner-search.js(1 hunks)
💤 Files with no reviewable changes (2)
- src/Digdir.Library.Dialogporten.WebApiClient/Services/EdDsaSecurityKeysCacheService.cs
- src/Digdir.Domain.Dialogporten.Application/Features/V1/EndUser/DialogSystemLabels/Commands/Set/SystemLabelCommand.cs
✅ Files skipped from review due to trivial changes (27)
- tests/k6/tests/serviceowner/performance/serviceowner-search.js
- tests/k6/common/token.js
- tests/k6/tests/serviceowner/performance/create-remove-dialog.js
- tests/k6/tests/serviceowner/dialogCreateIdempotentKey.js
- tests/k6/tests/serviceowner/performance/createTransmissionsWithThresholds.js
- tests/k6/tests/serviceowner/performance/create-transmissions.js
- tests/k6/tests/serviceowner/performance/purge-dialogs.js
- tests/k6/common/report.js
- tests/k6/common/describe.js
- tests/k6/tests/serviceowner/performance/createremove-no-delay.js
- tests/k6/tests/scenarios/performance/create-dialog-and-search.js
- src/Digdir.Domain.Dialogporten.Application/Features/V1/ServiceOwner/Dialogs/Queries/Search/SearchDialogQuery.cs
- tests/k6/tests/serviceowner/performance/createTransmissionsBreakpoint.js
- src/Digdir.Domain.Dialogporten.Application/Features/V1/EndUser/Dialogs/Queries/Search/SearchDialogQuery.cs
- tests/k6/scripts/generate_all_tests.ps1
- tests/k6/common/extend.js
- tests/k6/tests/performancetest_common/readTestdata.js
- tests/k6/tests/serviceowner/dialogCreateInvalidProcess.js
- tests/k6/tests/performancetest_data/01-create-dialog.js
- tests/k6/tests/graphql/performance/graphql-search.js
- tests/k6/tests/serviceowner/performance/createDialogWithThresholds.js
- tests/k6/tests/performancetest_common/getTokens.js
- tests/k6/tests/serviceowner/performance/createDialogBreakpoint.js
- tests/k6/tests/enduser/performance/enduser-search.js
- tests/k6/tests/performancetest_common/createDialog.js
- tests/k6/tests/performancetest_common/simpleSearch.js
- tests/k6/common/config.js
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: Dry run deploy apps / Deploy service to test
- GitHub Check: build / build-and-test
🔇 Additional comments (4)
tests/k6/common/dialog.js (2)
92-92: LGTM! Improved error message.Adding the process value to the error message enhances debugging capabilities.
165-166: LGTM! Improved code formatting.The adjusted indentation enhances code readability while maintaining the same functionality.
src/Digdir.Library.Dialogporten.WebApiClient/ServiceCollectionExtensions.cs (2)
17-17: LGTM!Good refactoring to extract the hardcoded string into a constant.
27-27: LGTM!The constant is used consistently, improving maintainability.
Also applies to: 40-40
knuhau
approved these changes
Feb 25, 2025
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.