fix: Allow new activities to reference old activities #935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oskogstad
force-pushed
the
fix/allow-new-activities-to-reference-old-activities
branch
from
e96278d to
12304e7
Compare
oskogstad
force-pushed
the
fix/allow-new-activities-to-reference-old-activities
branch
from
12304e7 to
7aa440e
Compare
oskogstad
force-pushed
the
fix/allow-new-activities-to-reference-old-activities
branch
from
7aa440e to
50c9acd
Compare
oskogstad
changed the title
|
knuhau
approved these changes
Jul 29, 2024
oskogstad
deleted the
fix/allow-new-activities-to-reference-old-activities
branch
arealmaas
pushed a commit
that referenced
this pull request
Jul 30, 2024
🤖 I have created a release *beep* *boop* --- ## [1.9.0](v1.8.1...v1.9.0) (2024-07-30) ### Features * **breaking:** Move front channel embeds to content ([#862](#862)) ([c9b50e9](c9b50e9)) * **breaking:** Remove DialogElements, add Attachments ([#867](#867)) ([dbe296a](dbe296a)) * **breaking:** Remove PUT/DELETE endpoints for DialogElements ([#844](#844)) ([51eb898](51eb898)) * **breaking:** Rename CultureCode to LanguageCode ([#871](#871)) ([96d50fc](96d50fc)) * **breaking:** Renaming dialog activity types ([#919](#919)) ([af262b1](af262b1)) * Change content array to object with properties for each content type ([#905](#905)) ([d549f19](d549f19)) * Implement actor entity ([#912](#912)) ([a635fcb](a635fcb)) * Introduce Transmissions ([#932](#932)) ([3ca495f](3ca495f)) * Rename DialogStatus enum values ([#915](#915)) ([5aea32b](5aea32b)) * **WebAPI:** Add Transmission endpoints ([#943](#943)) ([d608ade](d608ade)) ### Bug Fixes * Allow new activities to reference old activities ([#935](#935)) ([bbc443e](bbc443e)) * **auth:** Malformed JWTs no longer results in InternalServerError ([#870](#870)) ([5f2f386](5f2f386)) * **slackNotifier:** Add missing deployment of Slack notifier function in staging environment ([#861](#861)) ([59091f7](59091f7)) * Update e2e tests for actor model ([#918](#918)) ([ec1fcb1](ec1fcb1)) * **WebAPI:** Allow purging of softly deleted dialogs ([#940](#940)) ([c527c9f](c527c9f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It is currently not possible to create a new DialogActivity that refers to an old DialogActivity via
relatedActivityIdThis check in the validator requires the referred Id to be present in the DTO, which we don't allow.
This suggestion is to move this check from the validator to the handler and load all activities to verify the relation ID.
Related Issue(s)
Verification
Documentation
docs-directory, Altinnpedia or a separate linked PR in altinn-studio-docs., if applicable)