Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show and hide Clickable Area with a switch or toggle click through with a switch #17

Closed
3dsf opened this issue Jan 25, 2023 · 14 comments
Closed

Comments

@3dsf
Copy link

3dsf commented Jan 25, 2023

The Clickable Area might be confusing to video viewers.
Replacing with an icon or darkening a corner may be better.

Or renaming to Key Display Area might be appropriate.

@AlynxZhou
Copy link
Owner

Or renaming to Key Display Area might be appropriate.

No, it means "you can only drag here to move the floating window". That's why it is called Clickable Area, other area is click-through.

Maybe using other difference to hint the area is OK, but needs a better idea.

@latipun7
Copy link

latipun7 commented Feb 5, 2023

Sorry to necro-bump this issue.
Maybe an option to hide the Clickable Area would be preferred. So, user can still move the keys overlay, then hide that clickable area if the position is desirable, that way, the viewer didn't get bothered by Clickable Area.

@AlynxZhou
Copy link
Owner

Sorry to necro-bump this issue. Maybe an option to hide the Clickable Area would be preferred. So, user can still move the keys overlay, then hide that clickable area if the position is desirable, that way, the viewer didn't get bothered by Clickable Area.

Maybe not the best solution, but worth trying, I'd try this if I have time, thanks.

@AlynxZhou AlynxZhou reopened this Feb 5, 2023
@AlynxZhou AlynxZhou changed the title [Request] Remove 'Clickable Area' Show and hide Clickable Area with a switch Feb 5, 2023
@AlynxZhou
Copy link
Owner

Because compositor may not preserve window position on next shown, maybe the switch should be auto enable when the floating window shows up, instead of remember its state.

If anyone has a better idea, please tell me, it's worth trying.

@latipun7
Copy link

latipun7 commented Feb 6, 2023

I'm fine with that. Whenever this app runs, the Clickable Area is shown by default. Didn't need to remember the previous state. IMO.

@AlynxZhou
Copy link
Owner

image

Works like this, but I then have another idea that how about make window normal on show up and then use a switch to enable click through, so user can manually change window size.

@latipun7
Copy link

latipun7 commented Feb 7, 2023

Yes. That would be great instead of show & hide the Clickable Area. TBH, manually changing window size is my preference too.
Also, the padding at the top and bottom could be same length as well as left and right.

@AlynxZhou
Copy link
Owner

Also, the padding at the top and bottom could be same length as well as left and right.

I wish I could do this, but it's not padding, it's header bar, I just write some CSS to make it transparent and remove the split line. Setting header bar to NULL requires a remap of window, then you may lose your window position. You cannot remove header bar by default, because you need it to drag window, or call window manager menus, so that's the best I can do.

@AlynxZhou
Copy link
Owner

So now I have two branches: https://github.com/AlynxZhou/showmethekey/tree/click-through-switch and https://github.com/AlynxZhou/showmethekey/tree/hide-handle.

click-through-switch allows user manually move or resize the keys window, which is good, but it adds an extra step that requires user toggle the switch, we already have some extra steps before usable in Wayland.

I personally prefer it, but I am waiting for other people's opinions here.

@AlynxZhou AlynxZhou changed the title Show and hide Clickable Area with a switch Show and hide Clickable Area with a switch or toggle click through with a switch Feb 7, 2023
@raffaem
Copy link

raffaem commented Feb 7, 2023

So now I have two branches: https://github.com/AlynxZhou/showmethekey/tree/click-through-switch and https://github.com/AlynxZhou/showmethekey/tree/hide-handle.

click-through-switch allows user manually move or resize the keys window, which is good, but it adds an extra step that requires user toggle the switch, we already have some extra steps before usable in Wayland.

I personally prefer it, but I am waiting for other people's opinions here.

Yeah, I use a tiling window manager, and with the [click-through-switch](https://github.com/AlynxZhou/showmethekey/tree/click-through-switch) branch, I can both tile and resize the window that shows the key.

With master I could resize it, but I couldn't tile it.

Thanks.

@raffaem
Copy link

raffaem commented Feb 7, 2023

Or renaming to Key Display Area might be appropriate.

No, it means "you can only drag here to move the floating window". That's why it is called Clickable Area, other area is click-through.

Maybe using other difference to hint the area is OK, but needs a better idea.

Well, I'm tiling it to display it at the bottom of my screen, with its own space, and all the other windows around it, so I don't need any "click-through" since there is no window beneath it

@3dsf
Copy link
Author

3dsf commented Feb 9, 2023

@AlynxZhou

I prefer the click-through-switch version too.

Thank you

@AlynxZhou
Copy link
Owner

I'll try to do this soon. Sorry for late reply.

AlynxZhou added a commit that referenced this issue Aug 30, 2023
@AlynxZhou
Copy link
Owner

Finished in b0a6013.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants